Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9403)

Unified Diff: chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h
diff --git a/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h b/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h
index 610283e2f839219314a2e91eeb163e94fda1029d..f87b88a8b9e87b05a6155341978354b97f4f4946 100644
--- a/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h
+++ b/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.h
@@ -47,24 +47,27 @@ class FakePageTimingMetricsIPCSender : public IPC::Sender {
// PageLoadTimings that are expected to be sent through Send() should be
// passed to ExpectPageLoadTiming.
- void ExpectPageLoadTiming(const PageLoadTiming& timing);
+ void ExpectPageLoadTiming(const mojom::PageLoadTiming& timing);
// Forces verification that actual timings sent through Send match
// expected timings provided via ExpectPageLoadTiming.
void VerifyExpectedTimings() const;
- const std::vector<PageLoadTiming>& expected_timings() const {
+ const std::vector<mojo::StructPtr<mojom::PageLoadTiming>>& expected_timings()
+ const {
return expected_timings_;
}
- const std::vector<PageLoadTiming>& actual_timings() const {
+ const std::vector<mojo::StructPtr<mojom::PageLoadTiming>>& actual_timings()
+ const {
return actual_timings_;
}
private:
- void OnTimingUpdated(const PageLoadTiming& timing, PageLoadMetadata metadata);
+ void OnTimingUpdated(const mojom::PageLoadTiming& timing,
+ mojom::PageLoadMetadata metadata);
- std::vector<PageLoadTiming> expected_timings_;
- std::vector<PageLoadTiming> actual_timings_;
+ std::vector<mojo::StructPtr<mojom::PageLoadTiming>> expected_timings_;
+ std::vector<mojo::StructPtr<mojom::PageLoadTiming>> actual_timings_;
};
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698