Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index c6a2dd46c92d9ed53048c2bb8f35aca62171db0c..4e82e00f14bbf2b011c2a51a26ff43ed2c1d7831 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -572,8 +572,8 @@ MetricsWebContentsObserver::NotifyAbortedProvisionalLoadsNewNavigation(
void MetricsWebContentsObserver::OnTimingUpdated(
content::RenderFrameHost* render_frame_host,
- const PageLoadTiming& timing,
- const PageLoadMetadata& metadata) {
+ const mojom::PageLoadTiming& timing,
+ const mojom::PageLoadMetadata& metadata) {
// We may receive notifications from frames that have been navigated away
// from. We simply ignore them.
if (GetMainFrame(render_frame_host) != web_contents()->GetMainFrame()) {
@@ -602,7 +602,7 @@ void MetricsWebContentsObserver::OnTimingUpdated(
if (render_frame_host->GetParent() != nullptr) {
// Child frames may send PageLoadMetadata updates, but not PageLoadTiming
// updates.
- if (!timing.IsEmpty())
+ if (!IsEmpty(timing))
RecordInternalError(ERR_TIMING_IPC_FROM_SUBFRAME);
committed_load_->UpdateChildFrameMetadata(metadata);
return;

Powered by Google App Engine
This is Rietveld 408576698