Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Fixed tests and addressed comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index 3fb3cf44336a173d24de353b9eeebf7f1ae89186..da3b827818a141af996598a4691bf9c132e5a355 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -3435,8 +3435,9 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, FirstContentfulPaintTimingSimple) {
observer.SetNavigationStartTicksForTesting(load_start);
page_load_metrics::PageLoadTiming timing;
+ page_load_metrics::InitPageLoadTimingForTest(&timing);
timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.
- timing.paint_timing.first_contentful_paint =
+ timing.paint_timing->first_contentful_paint =
base::TimeDelta::FromMilliseconds(2654);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
@@ -3476,8 +3477,9 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, FirstContentfulPaintTimingReuse) {
observer.SetNavigationStartTicksForTesting(load_start);
page_load_metrics::PageLoadTiming timing;
+ page_load_metrics::InitPageLoadTimingForTest(&timing);
timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.
- timing.paint_timing.first_contentful_paint =
+ timing.paint_timing->first_contentful_paint =
base::TimeDelta::FromMilliseconds(2361);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
@@ -3517,8 +3519,9 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
observer.SetNavigationStartTicksForTesting(load_start);
page_load_metrics::PageLoadTiming timing;
+ page_load_metrics::InitPageLoadTimingForTest(&timing);
timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.
- timing.paint_timing.first_contentful_paint =
+ timing.paint_timing->first_contentful_paint =
base::TimeDelta::FromMilliseconds(2361);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
@@ -3560,8 +3563,9 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
observer.SetNavigationStartTicksForTesting(clock->NowTicks());
page_load_metrics::PageLoadTiming timing;
+ page_load_metrics::InitPageLoadTimingForTest(&timing);
timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.
- timing.paint_timing.first_contentful_paint =
+ timing.paint_timing->first_contentful_paint =
base::TimeDelta::FromMilliseconds(2362);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
@@ -3609,9 +3613,10 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
observer.SetNavigationStartTicksForTesting(load_start);
page_load_metrics::PageLoadTiming timing;
+ page_load_metrics::InitPageLoadTimingForTest(&timing);
timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.
// The FCP time should end up on the edge of the bucket.
- timing.paint_timing.first_contentful_paint =
+ timing.paint_timing->first_contentful_paint =
base::TimeDelta::FromMilliseconds(2654);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
@@ -3641,8 +3646,9 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, FirstContentfulPaintHidden) {
GenericPageLoadExtraInfo(dest_url())));
page_load_metrics::PageLoadTiming timing;
+ page_load_metrics::InitPageLoadTimingForTest(&timing);
timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.
- timing.paint_timing.first_contentful_paint =
+ timing.paint_timing->first_contentful_paint =
base::TimeDelta::FromMilliseconds(2654);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);
@@ -3686,8 +3692,9 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
GenericPageLoadExtraInfo(dest_url())));
page_load_metrics::PageLoadTiming timing;
+ page_load_metrics::InitPageLoadTimingForTest(&timing);
timing.navigation_start = base::Time::FromDoubleT(1); // Non-null time.
- timing.paint_timing.first_contentful_paint =
+ timing.paint_timing->first_contentful_paint =
base::TimeDelta::FromMilliseconds(2362);
page_load_metrics::PageLoadMetricsObserverTestHarness::
PopulateRequiredTimingFields(&timing);

Powered by Google App Engine
This is Rietveld 408576698