chrome/browser/page_load_metrics/page_load_metrics_observer.cc - Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)

Patch Set: Fixed tests and addressed comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

index 997e7f9f37508952a6ab14041fec1ac09eb81206..996eb92213892d92eb6e925dbf144b547831e86a 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc

@@ -52,8 +52,8 @@ PageLoadExtraInfo PageLoadExtraInfo::CreateForTesting(

UserInitiatedInfo::BrowserInitiated(), url, url, true /* did_commit */,

page_load_metrics::END_NONE,

page_load_metrics::UserInitiatedInfo::NotUserInitiated(),

- base::TimeDelta(), page_load_metrics::PageLoadMetadata(),

- page_load_metrics::PageLoadMetadata());

+ base::TimeDelta(), page_load_metrics::mojom::PageLoadMetadata(),

+ page_load_metrics::mojom::PageLoadMetadata());

}

ExtraRequestCompleteInfo::ExtraRequestCompleteInfo(