chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc - Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)

Patch Set: Fixed tests and addressed comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h » ('j') | chrome/common/page_load_metrics/page_load_metrics.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

index 9b90abb1cabbe19aec8dffe280d364a93291a29d..39a4b2d6c96159624fdbace19f8b4f212bfe562e 100644

--- a/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc

@@ -141,7 +141,7 @@ AdsPageLoadMetricsObserver::OnDidFinishSubFrameNavigation(

page_load_metrics::PageLoadMetricsObserver::ObservePolicy

AdsPageLoadMetricsObserver::FlushMetricsOnAppEnterBackground(

- const page_load_metrics::PageLoadTiming& timing,

+ const page_load_metrics::mojom::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) {

// The browser may come back, but there is no guarantee. To be safe, record

// what we have now and ignore future changes to this navigation.

@@ -157,7 +157,7 @@ void AdsPageLoadMetricsObserver::OnLoadedResource(

}

void AdsPageLoadMetricsObserver::OnComplete(

- const page_load_metrics::PageLoadTiming& timing,

+ const page_load_metrics::mojom::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) {

RecordHistograms();

}