chrome/browser/page_load_metrics/metrics_web_contents_observer.cc - Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)

Patch Set: Fixed tests and addressed comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

index c75afcf77008fc1cbe486ffe2a98184705031ce0..bb2a2761617172633790438b4382c00b5ca50140 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

@@ -598,7 +598,7 @@ void MetricsWebContentsObserver::OnTimingUpdated(

if (render_frame_host->GetParent() != nullptr) {

// Child frames may send PageLoadMetadata updates, but not PageLoadTiming

// updates.

- if (!timing.IsEmpty())

+ if (!IsEmpty(timing))

RecordInternalError(ERR_TIMING_IPC_FROM_SUBFRAME);

committed_load_->UpdateChildFrameMetadata(metadata);

return;