Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
index 181c30de2d376a2d3e5ea9fcb644900d2fd0d1f9..65d6341c931390a3053510c3491bc6ee7d308d2e 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
@@ -20,8 +20,8 @@ PageLoadExtraInfo::PageLoadExtraInfo(
PageEndReason page_end_reason,
UserInitiatedInfo page_end_user_initiated_info,
const base::Optional<base::TimeDelta>& page_end_time,
- const PageLoadMetadata& main_frame_metadata,
- const PageLoadMetadata& subframe_metadata)
+ const mojom::PageLoadMetadata& main_frame_metadata,
+ const mojom::PageLoadMetadata& subframe_metadata)
: navigation_start(navigation_start),
first_background_time(first_background_time),
first_foreground_time(first_foreground_time),
@@ -52,8 +52,8 @@ PageLoadExtraInfo PageLoadExtraInfo::CreateForTesting(
UserInitiatedInfo::BrowserInitiated(), url, url, true /* did_commit */,
page_load_metrics::END_NONE,
page_load_metrics::UserInitiatedInfo::NotUserInitiated(),
- base::TimeDelta(), page_load_metrics::PageLoadMetadata(),
- page_load_metrics::PageLoadMetadata());
+ base::TimeDelta(), page_load_metrics::mojom::PageLoadMetadata(),
+ page_load_metrics::mojom::PageLoadMetadata());
}
ExtraRequestCompleteInfo::ExtraRequestCompleteInfo(
@@ -113,7 +113,7 @@ PageLoadMetricsObserver::OnDidFinishSubFrameNavigation(
}
PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnHidden(
- const PageLoadTiming& timing,
+ const mojom::PageLoadTiming& timing,
const PageLoadExtraInfo& extra_info) {
return CONTINUE_OBSERVING;
}
@@ -124,7 +124,7 @@ PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnShown() {
PageLoadMetricsObserver::ObservePolicy
PageLoadMetricsObserver::FlushMetricsOnAppEnterBackground(
- const PageLoadTiming& timing,
+ const mojom::PageLoadTiming& timing,
const PageLoadExtraInfo& extra_info) {
return CONTINUE_OBSERVING;
}
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/page_load_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698