Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6739)

Unified Diff: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
index 981cdc0bdf820e257c805d9f71a18651b2435bb0..2e24c0b3cca2cf5cfffee53f450fbd924f97ca67 100644
--- a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
@@ -57,24 +57,25 @@ class UkmPageLoadMetricsObserver
ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
ObservePolicy FlushMetricsOnAppEnterBackground(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
ObservePolicy OnHidden(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnFailedProvisionalLoad(
const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
- void OnComplete(const page_load_metrics::PageLoadTiming& timing,
+ void OnComplete(const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
private:
// Records page load timing related metrics available in PageLoadTiming, such
// as first contentful paint.
- void RecordTimingMetrics(const page_load_metrics::PageLoadTiming& timing);
+ void RecordTimingMetrics(
+ const page_load_metrics::mojom::PageLoadTiming& timing);
// Records metrics based on the PageLoadExtraInfo struct, as well as updating
// the URL. |app_background_time| should be set to a timestamp if the app was

Powered by Google App Engine
This is Rietveld 408576698