Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc
index 7cbfd20e9079b8b7ed3451147cdcd449566c4482..1251655d6a57d4301e77b00951ebdee1dcc28998 100644
--- a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc
@@ -38,11 +38,12 @@ class ResourcePrefetchPredictorPageLoadMetricsObserverTest
predictor_ =
base::MakeUnique<testing::StrictMock<MockResourcePrefetchPredictor>>(
config, profile());
+ page_load_metrics::InitPageLoadTimingForTest(&timing_);
timing_.navigation_start = base::Time::FromDoubleT(1);
- timing_.paint_timing.first_paint = base::TimeDelta::FromSeconds(2);
- timing_.paint_timing.first_contentful_paint =
+ timing_.paint_timing->first_paint = base::TimeDelta::FromSeconds(2);
+ timing_.paint_timing->first_contentful_paint =
base::TimeDelta::FromSeconds(3);
- timing_.paint_timing.first_meaningful_paint =
+ timing_.paint_timing->first_meaningful_paint =
base::TimeDelta::FromSeconds(4);
PopulateRequiredTimingFields(&timing_);
}
@@ -55,7 +56,7 @@ class ResourcePrefetchPredictorPageLoadMetricsObserverTest
std::unique_ptr<testing::StrictMock<MockResourcePrefetchPredictor>>
predictor_;
- page_load_metrics::PageLoadTiming timing_;
+ page_load_metrics::mojom::PageLoadTiming timing_;
};
TEST_F(ResourcePrefetchPredictorPageLoadMetricsObserverTest,

Powered by Google App Engine
This is Rietveld 408576698