Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3287)

Unified Diff: chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc
index d230d5133c3b4181fd9386919c35b184acf4463a..f01c3de23f686dc919c4a84f68854016d86c4bda 100644
--- a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc
@@ -17,17 +17,19 @@ class ProtocolPageLoadMetricsObserverTest
tracker->AddObserver(std::move(observer));
}
- void InitializeTestPageLoadTiming(page_load_metrics::PageLoadTiming* timing) {
+ void InitializeTestPageLoadTiming(
+ page_load_metrics::mojom::PageLoadTiming* timing) {
+ page_load_metrics::InitPageLoadTimingForTest(timing);
timing->navigation_start = base::Time::FromDoubleT(1);
- timing->parse_timing.parse_start = base::TimeDelta::FromMilliseconds(100);
- timing->paint_timing.first_paint = base::TimeDelta::FromMilliseconds(200);
- timing->paint_timing.first_contentful_paint =
+ timing->parse_timing->parse_start = base::TimeDelta::FromMilliseconds(100);
+ timing->paint_timing->first_paint = base::TimeDelta::FromMilliseconds(200);
+ timing->paint_timing->first_contentful_paint =
base::TimeDelta::FromMilliseconds(300);
- timing->paint_timing.first_meaningful_paint =
+ timing->paint_timing->first_meaningful_paint =
base::TimeDelta::FromMilliseconds(400);
- timing->document_timing.dom_content_loaded_event_start =
+ timing->document_timing->dom_content_loaded_event_start =
base::TimeDelta::FromMilliseconds(600);
- timing->document_timing.load_event_start =
+ timing->document_timing->load_event_start =
base::TimeDelta::FromMilliseconds(1000);
PopulateRequiredTimingFields(timing);
}
@@ -40,7 +42,7 @@ class ProtocolPageLoadMetricsObserverTest
// NavigationHandle.
observer_->connection_info_ = connection_info;
- page_load_metrics::PageLoadTiming timing;
+ page_load_metrics::mojom::PageLoadTiming timing;
InitializeTestPageLoadTiming(&timing);
SimulateTimingUpdate(timing);

Powered by Google App Engine
This is Rietveld 408576698