Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc
index 66a311dd631dd70c7c6153c2584b26a5fd05ae99..983cfff3d3f38ab197c5a11d8ea518c94ca1489a 100644
--- a/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc
@@ -46,7 +46,7 @@ OmniboxSuggestionUsedMetricsObserver::~OmniboxSuggestionUsedMetricsObserver() {}
page_load_metrics::PageLoadMetricsObserver::ObservePolicy
OmniboxSuggestionUsedMetricsObserver::OnHidden(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
return STOP_OBSERVING;
}
@@ -61,9 +61,9 @@ OmniboxSuggestionUsedMetricsObserver::OnCommit(
}
void OmniboxSuggestionUsedMetricsObserver::OnFirstContentfulPaintInPage(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
- base::TimeDelta fcp = timing.paint_timing.first_contentful_paint.value();
+ base::TimeDelta fcp = timing.paint_timing->first_contentful_paint.value();
if (info.started_in_foreground) {
if (ui::PageTransitionCoreTypeIs(transition_type_,
@@ -97,9 +97,9 @@ void OmniboxSuggestionUsedMetricsObserver::OnFirstContentfulPaintInPage(
void OmniboxSuggestionUsedMetricsObserver::
OnFirstMeaningfulPaintInMainFrameDocument(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
- base::TimeDelta fmp = timing.paint_timing.first_meaningful_paint.value();
+ base::TimeDelta fmp = timing.paint_timing->first_meaningful_paint.value();
if (info.started_in_foreground) {
if (ui::PageTransitionCoreTypeIs(transition_type_,

Powered by Google App Engine
This is Rietveld 408576698