Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1637)

Unified Diff: chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer.h

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer.h
index a6620e9fe8c542bf1067dee6b2d63ab6f986cbc6..ecab44a93b14a6b7851373f4b2fea0fe1ce7f502 100644
--- a/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/lofi_page_load_metrics_observer.h
@@ -14,11 +14,6 @@ namespace content {
class NavigationHandle;
}
-namespace page_load_metrics {
-struct PageLoadExtraInfo;
-struct PageLoadTiming;
-}
-
namespace data_reduction_proxy {
namespace lofi_names {
@@ -51,16 +46,17 @@ class LoFiPageLoadMetricsObserver
const GURL& currently_committed_url,
bool started_in_foreground) override;
ObservePolicy FlushMetricsOnAppEnterBackground(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
- void OnComplete(const page_load_metrics::PageLoadTiming& timing,
+ void OnComplete(const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnLoadedResource(const page_load_metrics::ExtraRequestCompleteInfo&
extra_request_complete_info) override;
private:
- void RecordTimingMetrics(const page_load_metrics::PageLoadTiming& timing,
- const page_load_metrics::PageLoadExtraInfo& info);
+ void RecordTimingMetrics(
+ const page_load_metrics::mojom::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info);
// Records UMA of page size when the observer is about to be deleted.
void RecordPageSizeUMA() const;

Powered by Google App Engine
This is Rietveld 408576698