chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc - Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)

Patch Set: Remove unnecessary variable Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc

index a88983c1f5dc669e0948c630c1c80b60fde3bb5b..36428b1cdf98796b95b0440641c022c1e14721c4 100644

--- a/chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc

@@ -137,9 +137,10 @@ TEST_F(DelayNavigationPageLoadMetricsObserverTest, NoMetricsWithoutNavigation) {

TEST_F(DelayNavigationPageLoadMetricsObserverTest, CommitWithPaint) {

NavigateToDefaultUrlAndCommit();

- page_load_metrics::PageLoadTiming timing;

+ page_load_metrics::mojom::PageLoadTiming timing;

+ page_load_metrics::InitPageLoadTimingForTest(&timing);

timing.navigation_start = base::Time::FromDoubleT(1);

- timing.paint_timing.first_paint = base::TimeDelta::FromMilliseconds(1);

+ timing.paint_timing->first_paint = base::TimeDelta::FromMilliseconds(1);

PopulateRequiredTimingFields(&timing);

SimulateTimingUpdate(timing);