Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
index 620fb96804bbdd77a61c473472a03ce9cd854984..ae2a4df19abd8c7f045f59d652546074d0e368ae 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
@@ -17,11 +17,6 @@ class BrowserContext;
class NavigationHandle;
}
-namespace page_load_metrics {
-struct PageLoadExtraInfo;
-struct PageLoadTiming;
-}
-
namespace data_reduction_proxy {
class DataReductionProxyData;
class DataReductionProxyPingbackClient;
@@ -74,43 +69,43 @@ class DataReductionProxyMetricsObserver
bool started_in_foreground) override;
ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;
ObservePolicy FlushMetricsOnAppEnterBackground(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
- void OnComplete(const page_load_metrics::PageLoadTiming& timing,
+ void OnComplete(const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnDomContentLoadedEventStart(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnLoadEventStart(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
- void OnFirstLayout(const page_load_metrics::PageLoadTiming& timing,
+ void OnFirstLayout(const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnFirstPaintInPage(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnFirstTextPaintInPage(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnFirstImagePaintInPage(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnFirstContentfulPaintInPage(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnFirstMeaningfulPaintInMainFrameDocument(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
- void OnParseStart(const page_load_metrics::PageLoadTiming& timing,
+ void OnParseStart(const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
- void OnParseStop(const page_load_metrics::PageLoadTiming& timing,
+ void OnParseStop(const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
void OnLoadedResource(const page_load_metrics::ExtraRequestCompleteInfo&
extra_request_compelte_info) override;
private:
// Sends the page load information to the pingback client.
- void SendPingback(const page_load_metrics::PageLoadTiming& timing,
+ void SendPingback(const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info,
bool app_background_occurred);

Powered by Google App Engine
This is Rietveld 408576698