chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc - Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)

Patch Set: Remove unnecessary variable Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc

index 4784920b763ecf0b8caa0a4856837285ca892138..bd2ee893918ce6800e4c00b9740c66eaafb217b0 100644

--- a/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc

@@ -21,11 +21,11 @@ AndroidPageLoadMetricsObserver::AndroidPageLoadMetricsObserver(

: web_contents_(web_contents) {}

void AndroidPageLoadMetricsObserver::OnFirstContentfulPaintInPage(

- const page_load_metrics::PageLoadTiming& timing,

+ const page_load_metrics::mojom::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

int64_t first_contentful_paint_ms =

- timing.paint_timing.first_contentful_paint->InMilliseconds();

+ timing.paint_timing->first_contentful_paint->InMilliseconds();

base::android::ScopedJavaLocalRef<jobject> java_web_contents =

web_contents_->GetJavaWebContents();

JNIEnv* env = base::android::AttachCurrentThread();

@@ -37,11 +37,11 @@ void AndroidPageLoadMetricsObserver::OnFirstContentfulPaintInPage(

}

void AndroidPageLoadMetricsObserver::OnLoadEventStart(

- const page_load_metrics::PageLoadTiming& timing,

+ const page_load_metrics::mojom::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& info) {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

int64_t load_event_start_ms =

- timing.document_timing.load_event_start->InMilliseconds();

+ timing.document_timing->load_event_start->InMilliseconds();

base::android::ScopedJavaLocalRef<jobject> java_web_contents =

web_contents_->GetJavaWebContents();

JNIEnv* env = base::android::AttachCurrentThread();