Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6674)

Unified Diff: chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc
index c53afe320cc678b7ba851026c76704361029c41b..30dd5f8dc35767751caca162311226ef37d1a85a 100644
--- a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc
@@ -77,59 +77,60 @@ AMPPageLoadMetricsObserver::OnCommit(
}
void AMPPageLoadMetricsObserver::OnDomContentLoadedEventStart(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
if (!WasStartedInForegroundOptionalEventInForeground(
- timing.document_timing.dom_content_loaded_event_start, info)) {
+ timing.document_timing->dom_content_loaded_event_start, info)) {
return;
}
RECORD_HISTOGRAM_FOR_TYPE(
kHistogramAMPDOMContentLoadedEventFired, view_type_,
- timing.document_timing.dom_content_loaded_event_start.value());
+ timing.document_timing->dom_content_loaded_event_start.value());
}
void AMPPageLoadMetricsObserver::OnLoadEventStart(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
if (!WasStartedInForegroundOptionalEventInForeground(
- timing.document_timing.load_event_start, info)) {
+ timing.document_timing->load_event_start, info)) {
return;
}
RECORD_HISTOGRAM_FOR_TYPE(kHistogramAMPLoadEventFired, view_type_,
- timing.document_timing.load_event_start.value());
+ timing.document_timing->load_event_start.value());
}
void AMPPageLoadMetricsObserver::OnFirstLayout(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
if (!WasStartedInForegroundOptionalEventInForeground(
- timing.document_timing.first_layout, info)) {
+ timing.document_timing->first_layout, info)) {
return;
}
RECORD_HISTOGRAM_FOR_TYPE(kHistogramAMPFirstLayout, view_type_,
- timing.document_timing.first_layout.value());
+ timing.document_timing->first_layout.value());
}
void AMPPageLoadMetricsObserver::OnFirstContentfulPaintInPage(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
if (!WasStartedInForegroundOptionalEventInForeground(
- timing.paint_timing.first_contentful_paint, info)) {
+ timing.paint_timing->first_contentful_paint, info)) {
return;
}
- RECORD_HISTOGRAM_FOR_TYPE(kHistogramAMPFirstContentfulPaint, view_type_,
- timing.paint_timing.first_contentful_paint.value());
+ RECORD_HISTOGRAM_FOR_TYPE(
+ kHistogramAMPFirstContentfulPaint, view_type_,
+ timing.paint_timing->first_contentful_paint.value());
}
void AMPPageLoadMetricsObserver::OnParseStart(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
if (!WasStartedInForegroundOptionalEventInForeground(
- timing.parse_timing.parse_start, info)) {
+ timing.parse_timing->parse_start, info)) {
return;
}
RECORD_HISTOGRAM_FOR_TYPE(kHistogramAMPParseStart, view_type_,
- timing.parse_timing.parse_start.value());
+ timing.parse_timing->parse_start.value());
}
// static

Powered by Google App Engine
This is Rietveld 408576698