Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc » ('j') | chrome/common/page_load_metrics/page_load_metrics.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
index 2b2015211ebf28f3210fd60c787596c85d6cd868..17b0d60a33e66e6db70afc64d705e698a14f509f 100644
--- a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
@@ -23,13 +23,13 @@ ProtocolPageLoadMetricsObserver::OnCommit(
page_load_metrics::PageLoadMetricsObserver::ObservePolicy
ProtocolPageLoadMetricsObserver::OnHidden(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
return STOP_OBSERVING;
}
void ProtocolPageLoadMetricsObserver::OnParseStart(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
switch (connection_info_) {
case net::HttpResponseInfo::CONNECTION_INFO_UNKNOWN:
@@ -44,12 +44,12 @@ void ProtocolPageLoadMetricsObserver::OnParseStart(
case net::HttpResponseInfo::CONNECTION_INFO_HTTP1_1:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H11.ParseTiming.NavigationToParseStart",
- timing.parse_timing.parse_start.value());
+ timing.parse_timing->parse_start.value());
break;
case net::HttpResponseInfo::CONNECTION_INFO_HTTP2:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H2.ParseTiming.NavigationToParseStart",
- timing.parse_timing.parse_start.value());
+ timing.parse_timing->parse_start.value());
break;
case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
@@ -62,13 +62,13 @@ void ProtocolPageLoadMetricsObserver::OnParseStart(
case net::HttpResponseInfo::CONNECTION_INFO_QUIC_39:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.ParseTiming.NavigationToParseStart",
- timing.parse_timing.parse_start.value());
+ timing.parse_timing->parse_start.value());
break;
}
}
void ProtocolPageLoadMetricsObserver::OnFirstContentfulPaint(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
switch (connection_info_) {
case net::HttpResponseInfo::CONNECTION_INFO_UNKNOWN:
@@ -84,23 +84,23 @@ void ProtocolPageLoadMetricsObserver::OnFirstContentfulPaint(
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H11.PaintTiming."
"NavigationToFirstContentfulPaint",
- timing.paint_timing.first_contentful_paint.value());
+ timing.paint_timing->first_contentful_paint.value());
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H11.PaintTiming."
"ParseStartToFirstContentfulPaint",
- timing.paint_timing.first_contentful_paint.value() -
- timing.parse_timing.parse_start.value());
+ timing.paint_timing->first_contentful_paint.value() -
+ timing.parse_timing->parse_start.value());
break;
case net::HttpResponseInfo::CONNECTION_INFO_HTTP2:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H2.PaintTiming."
"NavigationToFirstContentfulPaint",
- timing.paint_timing.first_contentful_paint.value());
+ timing.paint_timing->first_contentful_paint.value());
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H2.PaintTiming."
"ParseStartToFirstContentfulPaint",
- timing.paint_timing.first_contentful_paint.value() -
- timing.parse_timing.parse_start.value());
+ timing.paint_timing->first_contentful_paint.value() -
+ timing.parse_timing->parse_start.value());
break;
case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
@@ -114,18 +114,18 @@ void ProtocolPageLoadMetricsObserver::OnFirstContentfulPaint(
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.PaintTiming."
"NavigationToFirstContentfulPaint",
- timing.paint_timing.first_contentful_paint.value());
+ timing.paint_timing->first_contentful_paint.value());
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.PaintTiming."
"ParseStartToFirstContentfulPaint",
- timing.paint_timing.first_contentful_paint.value() -
- timing.parse_timing.parse_start.value());
+ timing.paint_timing->first_contentful_paint.value() -
+ timing.parse_timing->parse_start.value());
break;
}
}
void ProtocolPageLoadMetricsObserver::OnFirstMeaningfulPaint(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
switch (connection_info_) {
case net::HttpResponseInfo::CONNECTION_INFO_UNKNOWN:
@@ -141,23 +141,23 @@ void ProtocolPageLoadMetricsObserver::OnFirstMeaningfulPaint(
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H11.Experimental.PaintTiming."
"NavigationToFirstMeaningfulPaint",
- timing.paint_timing.first_meaningful_paint.value());
+ timing.paint_timing->first_meaningful_paint.value());
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H11.Experimental.PaintTiming."
"ParseStartToFirstMeaningfulPaint",
- timing.paint_timing.first_meaningful_paint.value() -
- timing.parse_timing.parse_start.value());
+ timing.paint_timing->first_meaningful_paint.value() -
+ timing.parse_timing->parse_start.value());
break;
case net::HttpResponseInfo::CONNECTION_INFO_HTTP2:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H2.Experimental.PaintTiming."
"NavigationToFirstMeaningfulPaint",
- timing.paint_timing.first_meaningful_paint.value());
+ timing.paint_timing->first_meaningful_paint.value());
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H2.Experimental.PaintTiming."
"ParseStartToFirstMeaningfulPaint",
- timing.paint_timing.first_meaningful_paint.value() -
- timing.parse_timing.parse_start.value());
+ timing.paint_timing->first_meaningful_paint.value() -
+ timing.parse_timing->parse_start.value());
break;
case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
@@ -171,18 +171,18 @@ void ProtocolPageLoadMetricsObserver::OnFirstMeaningfulPaint(
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.Experimental.PaintTiming."
"NavigationToFirstMeaningfulPaint",
- timing.paint_timing.first_meaningful_paint.value());
+ timing.paint_timing->first_meaningful_paint.value());
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.Experimental.PaintTiming."
"ParseStartToFirstMeaningfulPaint",
- timing.paint_timing.first_meaningful_paint.value() -
- timing.parse_timing.parse_start.value());
+ timing.paint_timing->first_meaningful_paint.value() -
+ timing.parse_timing->parse_start.value());
break;
}
}
void ProtocolPageLoadMetricsObserver::OnDomContentLoadedEventStart(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
switch (connection_info_) {
case net::HttpResponseInfo::CONNECTION_INFO_UNKNOWN:
@@ -198,13 +198,13 @@ void ProtocolPageLoadMetricsObserver::OnDomContentLoadedEventStart(
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H11.DocumentTiming."
"NavigationToDOMContentLoadedEventFired",
- timing.document_timing.dom_content_loaded_event_start.value());
+ timing.document_timing->dom_content_loaded_event_start.value());
break;
case net::HttpResponseInfo::CONNECTION_INFO_HTTP2:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H2.DocumentTiming."
"NavigationToDOMContentLoadedEventFired",
- timing.document_timing.dom_content_loaded_event_start.value());
+ timing.document_timing->dom_content_loaded_event_start.value());
break;
case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
@@ -218,13 +218,13 @@ void ProtocolPageLoadMetricsObserver::OnDomContentLoadedEventStart(
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.DocumentTiming."
"NavigationToDOMContentLoadedEventFired",
- timing.document_timing.dom_content_loaded_event_start.value());
+ timing.document_timing->dom_content_loaded_event_start.value());
break;
}
}
void ProtocolPageLoadMetricsObserver::OnLoadEventStart(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) {
switch (connection_info_) {
case net::HttpResponseInfo::CONNECTION_INFO_UNKNOWN:
@@ -240,13 +240,13 @@ void ProtocolPageLoadMetricsObserver::OnLoadEventStart(
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H11.DocumentTiming."
"NavigationToLoadEventFired",
- timing.document_timing.load_event_start.value());
+ timing.document_timing->load_event_start.value());
break;
case net::HttpResponseInfo::CONNECTION_INFO_HTTP2:
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.H2.DocumentTiming."
"NavigationToLoadEventFired",
- timing.document_timing.load_event_start.value());
+ timing.document_timing->load_event_start.value());
break;
case net::HttpResponseInfo::CONNECTION_INFO_QUIC_UNKNOWN_VERSION:
case net::HttpResponseInfo::CONNECTION_INFO_QUIC_32:
@@ -260,7 +260,7 @@ void ProtocolPageLoadMetricsObserver::OnLoadEventStart(
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.Protocol.QUIC.DocumentTiming."
"NavigationToLoadEventFired",
- timing.document_timing.load_event_start.value());
+ timing.document_timing->load_event_start.value());
break;
}
}
« no previous file with comments | « chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc » ('j') | chrome/common/page_load_metrics/page_load_metrics.mojom » ('J')

Powered by Google App Engine
This is Rietveld 408576698