Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h » ('j') | chrome/common/page_load_metrics/page_load_metrics.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
diff --git a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
index 27a685cd1e6cd5a438095680643244c2fe470754..5d122d92fa6cb828ccbeafccedc6f729354601c2 100644
--- a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
+++ b/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
@@ -54,67 +54,68 @@ PageLoadMetricsObserverTestHarness::~PageLoadMetricsObserverTestHarness() {}
// static
void PageLoadMetricsObserverTestHarness::PopulateRequiredTimingFields(
PageLoadTiming* inout_timing) {
- if (inout_timing->paint_timing.first_meaningful_paint &&
- !inout_timing->paint_timing.first_contentful_paint) {
- inout_timing->paint_timing.first_contentful_paint =
- inout_timing->paint_timing.first_meaningful_paint;
+ if (inout_timing->paint_timing->first_meaningful_paint &&
+ !inout_timing->paint_timing->first_contentful_paint) {
+ inout_timing->paint_timing->first_contentful_paint =
+ inout_timing->paint_timing->first_meaningful_paint;
}
- if ((inout_timing->paint_timing.first_text_paint ||
- inout_timing->paint_timing.first_image_paint ||
- inout_timing->paint_timing.first_contentful_paint) &&
- !inout_timing->paint_timing.first_paint) {
- inout_timing->paint_timing.first_paint =
- OptionalMin(OptionalMin(inout_timing->paint_timing.first_text_paint,
- inout_timing->paint_timing.first_image_paint),
- inout_timing->paint_timing.first_contentful_paint);
+ if ((inout_timing->paint_timing->first_text_paint ||
+ inout_timing->paint_timing->first_image_paint ||
+ inout_timing->paint_timing->first_contentful_paint) &&
+ !inout_timing->paint_timing->first_paint) {
+ inout_timing->paint_timing->first_paint =
+ OptionalMin(OptionalMin(inout_timing->paint_timing->first_text_paint,
+ inout_timing->paint_timing->first_image_paint),
+ inout_timing->paint_timing->first_contentful_paint);
}
- if (inout_timing->paint_timing.first_paint &&
- !inout_timing->document_timing.first_layout) {
- inout_timing->document_timing.first_layout =
- inout_timing->paint_timing.first_paint;
+ if (inout_timing->paint_timing->first_paint &&
+ !inout_timing->document_timing->first_layout) {
+ inout_timing->document_timing->first_layout =
+ inout_timing->paint_timing->first_paint;
}
- if (inout_timing->document_timing.load_event_start &&
- !inout_timing->document_timing.dom_content_loaded_event_start) {
- inout_timing->document_timing.dom_content_loaded_event_start =
- inout_timing->document_timing.load_event_start;
+ if (inout_timing->document_timing->load_event_start &&
+ !inout_timing->document_timing->dom_content_loaded_event_start) {
+ inout_timing->document_timing->dom_content_loaded_event_start =
+ inout_timing->document_timing->load_event_start;
}
- if (inout_timing->document_timing.first_layout &&
- !inout_timing->parse_timing.parse_start) {
- inout_timing->parse_timing.parse_start =
- inout_timing->document_timing.first_layout;
+ if (inout_timing->document_timing->first_layout &&
+ !inout_timing->parse_timing->parse_start) {
+ inout_timing->parse_timing->parse_start =
+ inout_timing->document_timing->first_layout;
}
- if (inout_timing->document_timing.dom_content_loaded_event_start &&
- !inout_timing->parse_timing.parse_stop) {
- inout_timing->parse_timing.parse_stop =
- inout_timing->document_timing.dom_content_loaded_event_start;
+ if (inout_timing->document_timing->dom_content_loaded_event_start &&
+ !inout_timing->parse_timing->parse_stop) {
+ inout_timing->parse_timing->parse_stop =
+ inout_timing->document_timing->dom_content_loaded_event_start;
}
- if (inout_timing->parse_timing.parse_stop &&
- !inout_timing->parse_timing.parse_start) {
- inout_timing->parse_timing.parse_start =
- inout_timing->parse_timing.parse_stop;
+ if (inout_timing->parse_timing->parse_stop &&
+ !inout_timing->parse_timing->parse_start) {
+ inout_timing->parse_timing->parse_start =
+ inout_timing->parse_timing->parse_stop;
}
- if (inout_timing->parse_timing.parse_start && !inout_timing->response_start) {
- inout_timing->response_start = inout_timing->parse_timing.parse_start;
+ if (inout_timing->parse_timing->parse_start &&
+ !inout_timing->response_start) {
+ inout_timing->response_start = inout_timing->parse_timing->parse_start;
}
- if (inout_timing->parse_timing.parse_start) {
- if (!inout_timing->parse_timing.parse_blocked_on_script_load_duration)
- inout_timing->parse_timing.parse_blocked_on_script_load_duration =
+ if (inout_timing->parse_timing->parse_start) {
+ if (!inout_timing->parse_timing->parse_blocked_on_script_load_duration)
+ inout_timing->parse_timing->parse_blocked_on_script_load_duration =
base::TimeDelta();
if (!inout_timing->parse_timing
- .parse_blocked_on_script_execution_duration) {
- inout_timing->parse_timing.parse_blocked_on_script_execution_duration =
+ ->parse_blocked_on_script_execution_duration) {
+ inout_timing->parse_timing->parse_blocked_on_script_execution_duration =
base::TimeDelta();
}
if (!inout_timing->parse_timing
- .parse_blocked_on_script_load_from_document_write_duration) {
+ ->parse_blocked_on_script_load_from_document_write_duration) {
inout_timing->parse_timing
- .parse_blocked_on_script_load_from_document_write_duration =
+ ->parse_blocked_on_script_load_from_document_write_duration =
base::TimeDelta();
}
if (!inout_timing->parse_timing
- .parse_blocked_on_script_execution_from_document_write_duration) {
+ ->parse_blocked_on_script_execution_from_document_write_duration) {
inout_timing->parse_timing
- .parse_blocked_on_script_execution_from_document_write_duration =
+ ->parse_blocked_on_script_execution_from_document_write_duration =
base::TimeDelta();
}
}
« no previous file with comments | « chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h » ('j') | chrome/common/page_load_metrics/page_load_metrics.mojom » ('J')

Powered by Google App Engine
This is Rietveld 408576698