Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2991)

Unified Diff: chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc
index 8dc995cf264d5796c49c3dbf4c7d2c41079c6b79..3a929994e20e099ad4e6a7242160160da13ac3ad 100644
--- a/chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc
@@ -30,13 +30,13 @@ CssScanningMetricsObserver::OnStart(
page_load_metrics::PageLoadMetricsObserver::ObservePolicy
CssScanningMetricsObserver::OnHidden(
- const page_load_metrics::PageLoadTiming&,
+ const page_load_metrics::mojom::PageLoadTiming&,
const page_load_metrics::PageLoadExtraInfo&) {
return STOP_OBSERVING;
}
void CssScanningMetricsObserver::OnFirstContentfulPaint(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
if (!css_preload_found_)
return;
@@ -44,12 +44,12 @@ void CssScanningMetricsObserver::OnFirstContentfulPaint(
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.CssScanner.PaintTiming."
"ParseStartToFirstContentfulPaint",
- timing.paint_timing.first_contentful_paint.value() -
- timing.parse_timing.parse_start.value());
+ timing.paint_timing->first_contentful_paint.value() -
+ timing.parse_timing->parse_start.value());
}
void CssScanningMetricsObserver::OnFirstMeaningfulPaint(
- const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::mojom::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) {
if (!css_preload_found_)
return;
@@ -57,6 +57,6 @@ void CssScanningMetricsObserver::OnFirstMeaningfulPaint(
PAGE_LOAD_HISTOGRAM(
"PageLoad.Clients.CssScanner.Experimental.PaintTiming."
"ParseStartToFirstMeaningfulPaint",
- timing.paint_timing.first_meaningful_paint.value() -
- timing.parse_timing.parse_start.value());
+ timing.paint_timing->first_meaningful_paint.value() -
+ timing.parse_timing->parse_start.value());
}

Powered by Google App Engine
This is Rietveld 408576698