Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" 5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 #include "base/timer/timer.h" 11 #include "base/timer/timer.h"
12 #include "chrome/common/page_load_metrics/page_load_metrics_messages.h" 12 #include "chrome/common/page_load_metrics/page_load_metrics_messages.h"
13 #include "ipc/ipc_sender.h" 13 #include "ipc/ipc_sender.h"
14 14
15 namespace page_load_metrics { 15 namespace page_load_metrics {
16 16
17 namespace { 17 namespace {
18 const int kInitialTimerDelayMillis = 50; 18 const int kInitialTimerDelayMillis = 50;
19 const int kTimerDelayMillis = 1000; 19 const int kTimerDelayMillis = 1000;
20 } // namespace 20 } // namespace
21 21
22 PageTimingMetricsSender::PageTimingMetricsSender( 22 PageTimingMetricsSender::PageTimingMetricsSender(
23 IPC::Sender* ipc_sender, 23 IPC::Sender* ipc_sender,
24 int routing_id, 24 int routing_id,
25 std::unique_ptr<base::Timer> timer, 25 std::unique_ptr<base::Timer> timer,
26 const PageLoadTiming& initial_timing) 26 mojom::PageLoadTimingPtr initial_timing)
27 : ipc_sender_(ipc_sender), 27 : ipc_sender_(ipc_sender),
28 routing_id_(routing_id), 28 routing_id_(routing_id),
29 timer_(std::move(timer)), 29 timer_(std::move(timer)),
30 last_timing_(initial_timing), 30 last_timing_(std::move(initial_timing)),
31 metadata_(PageLoadMetadata()) { 31 metadata_(mojom::PageLoadMetadata()) {
32 if (!initial_timing.IsEmpty()) { 32 if (!IsEmpty(*last_timing_)) {
33 EnsureSendTimer(); 33 EnsureSendTimer();
34 } 34 }
35 } 35 }
36 36
37 // On destruction, we want to send any data we have if we have a timer 37 // On destruction, we want to send any data we have if we have a timer
38 // currently running (and thus are talking to a browser process) 38 // currently running (and thus are talking to a browser process)
39 PageTimingMetricsSender::~PageTimingMetricsSender() { 39 PageTimingMetricsSender::~PageTimingMetricsSender() {
40 if (timer_->IsRunning()) { 40 if (timer_->IsRunning()) {
41 timer_->Stop(); 41 timer_->Stop();
42 SendNow(); 42 SendNow();
43 } 43 }
44 } 44 }
45 45
46 void PageTimingMetricsSender::DidObserveLoadingBehavior( 46 void PageTimingMetricsSender::DidObserveLoadingBehavior(
47 blink::WebLoadingBehaviorFlag behavior) { 47 blink::WebLoadingBehaviorFlag behavior) {
48 if (behavior & metadata_.behavior_flags) 48 if (behavior & metadata_.behavior_flags)
49 return; 49 return;
50 metadata_.behavior_flags |= behavior; 50 metadata_.behavior_flags |= behavior;
51 EnsureSendTimer(); 51 EnsureSendTimer();
52 } 52 }
53 53
54 void PageTimingMetricsSender::Send(const PageLoadTiming& timing) { 54 void PageTimingMetricsSender::Send(mojom::PageLoadTimingPtr timing) {
55 if (timing == last_timing_) 55 if (last_timing_->Equals(*timing))
56 return; 56 return;
57 57
58 // We want to make sure that each PageTimingMetricsSender is associated 58 // We want to make sure that each PageTimingMetricsSender is associated
59 // with a distinct page navigation. Because we reset the object on commit, 59 // with a distinct page navigation. Because we reset the object on commit,
60 // we can trash last_timing_ on a provisional load before SendNow() fires. 60 // we can trash last_timing_ on a provisional load before SendNow() fires.
61 if (!last_timing_.navigation_start.is_null() && 61 if (!last_timing_->navigation_start.is_null() &&
62 last_timing_.navigation_start != timing.navigation_start) { 62 last_timing_->navigation_start != timing->navigation_start) {
63 return; 63 return;
64 } 64 }
65 65
66 last_timing_ = timing; 66 last_timing_ = std::move(timing);
67 EnsureSendTimer(); 67 EnsureSendTimer();
68 } 68 }
69 69
70 void PageTimingMetricsSender::EnsureSendTimer() { 70 void PageTimingMetricsSender::EnsureSendTimer() {
71 if (!timer_->IsRunning()) { 71 if (!timer_->IsRunning()) {
72 // Send the first IPC eagerly to make sure the receiving side knows we're 72 // Send the first IPC eagerly to make sure the receiving side knows we're
73 // sending metrics as soon as possible. 73 // sending metrics as soon as possible.
74 int delay_ms = 74 int delay_ms =
75 have_sent_ipc_ ? kTimerDelayMillis : kInitialTimerDelayMillis; 75 have_sent_ipc_ ? kTimerDelayMillis : kInitialTimerDelayMillis;
76 timer_->Start( 76 timer_->Start(
77 FROM_HERE, base::TimeDelta::FromMilliseconds(delay_ms), 77 FROM_HERE, base::TimeDelta::FromMilliseconds(delay_ms),
78 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this))); 78 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this)));
79 } 79 }
80 } 80 }
81 81
82 void PageTimingMetricsSender::SendNow() { 82 void PageTimingMetricsSender::SendNow() {
83 have_sent_ipc_ = true; 83 have_sent_ipc_ = true;
84 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated( 84 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated(
85 routing_id_, last_timing_, metadata_)); 85 routing_id_, *last_timing_, metadata_));
86 } 86 }
87 87
88 } // namespace page_load_metrics 88 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698