Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h" 5 #include "chrome/renderer/page_load_metrics/page_timing_metrics_sender.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 #include "base/timer/timer.h" 11 #include "base/timer/timer.h"
12 #include "chrome/common/page_load_metrics/page_load_metrics_messages.h" 12 #include "chrome/common/page_load_metrics/page_load_metrics_messages.h"
13 #include "ipc/ipc_sender.h" 13 #include "ipc/ipc_sender.h"
14 14
15 namespace page_load_metrics { 15 namespace page_load_metrics {
16 16
17 namespace { 17 namespace {
18 const int kInitialTimerDelayMillis = 50; 18 const int kInitialTimerDelayMillis = 50;
19 const int kTimerDelayMillis = 1000; 19 const int kTimerDelayMillis = 1000;
20 } // namespace 20 } // namespace
21 21
22 PageTimingMetricsSender::PageTimingMetricsSender( 22 PageTimingMetricsSender::PageTimingMetricsSender(
23 IPC::Sender* ipc_sender, 23 IPC::Sender* ipc_sender,
24 int routing_id, 24 int routing_id,
25 std::unique_ptr<base::Timer> timer, 25 std::unique_ptr<base::Timer> timer,
26 const PageLoadTiming& initial_timing) 26 mojo::StructPtr<PageLoadTiming> initial_timing)
27 : ipc_sender_(ipc_sender), 27 : ipc_sender_(ipc_sender),
28 routing_id_(routing_id), 28 routing_id_(routing_id),
29 timer_(std::move(timer)), 29 timer_(std::move(timer)),
30 last_timing_(initial_timing), 30 last_timing_(std::move(initial_timing)),
31 metadata_(PageLoadMetadata()) { 31 metadata_(PageLoadMetadata()) {
32 if (!initial_timing.IsEmpty()) { 32 if (!IsEmpty(*last_timing_)) {
33 // Send an initial IPC relatively early to help track aborts. 33 // Send an initial IPC relatively early to help track aborts.
34 EnsureSendTimer(kInitialTimerDelayMillis); 34 EnsureSendTimer(kInitialTimerDelayMillis);
35 } 35 }
36 } 36 }
37 37
38 // On destruction, we want to send any data we have if we have a timer 38 // On destruction, we want to send any data we have if we have a timer
39 // currently running (and thus are talking to a browser process) 39 // currently running (and thus are talking to a browser process)
40 PageTimingMetricsSender::~PageTimingMetricsSender() { 40 PageTimingMetricsSender::~PageTimingMetricsSender() {
41 if (timer_->IsRunning()) { 41 if (timer_->IsRunning()) {
42 timer_->Stop(); 42 timer_->Stop();
43 SendNow(); 43 SendNow();
44 } 44 }
45 } 45 }
46 46
47 void PageTimingMetricsSender::DidObserveLoadingBehavior( 47 void PageTimingMetricsSender::DidObserveLoadingBehavior(
48 blink::WebLoadingBehaviorFlag behavior) { 48 blink::WebLoadingBehaviorFlag behavior) {
49 if (behavior & metadata_.behavior_flags) 49 if (behavior & metadata_.behavior_flags)
50 return; 50 return;
51 metadata_.behavior_flags |= behavior; 51 metadata_.behavior_flags |= behavior;
52 EnsureSendTimer(kTimerDelayMillis); 52 EnsureSendTimer(kTimerDelayMillis);
53 } 53 }
54 54
55 void PageTimingMetricsSender::Send(const PageLoadTiming& timing) { 55 void PageTimingMetricsSender::Send(mojo::StructPtr<PageLoadTiming> timing) {
56 if (timing == last_timing_) 56 if (last_timing_->Equals(*timing))
57 return; 57 return;
58 58
59 // We want to make sure that each PageTimingMetricsSender is associated 59 // We want to make sure that each PageTimingMetricsSender is associated
60 // with a distinct page navigation. Because we reset the object on commit, 60 // with a distinct page navigation. Because we reset the object on commit,
61 // we can trash last_timing_ on a provisional load before SendNow() fires. 61 // we can trash last_timing_ on a provisional load before SendNow() fires.
62 if (!last_timing_.navigation_start.is_null() && 62 if (!last_timing_->navigation_start.is_null() &&
63 last_timing_.navigation_start != timing.navigation_start) { 63 last_timing_->navigation_start != timing->navigation_start) {
64 return; 64 return;
65 } 65 }
66 66
67 last_timing_ = timing; 67 last_timing_ = std::move(timing);
68 EnsureSendTimer(kTimerDelayMillis); 68 EnsureSendTimer(kTimerDelayMillis);
69 } 69 }
70 70
71 void PageTimingMetricsSender::EnsureSendTimer(int delay) { 71 void PageTimingMetricsSender::EnsureSendTimer(int delay) {
72 if (!timer_->IsRunning()) 72 if (!timer_->IsRunning())
73 timer_->Start( 73 timer_->Start(
74 FROM_HERE, base::TimeDelta::FromMilliseconds(delay), 74 FROM_HERE, base::TimeDelta::FromMilliseconds(delay),
75 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this))); 75 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this)));
76 } 76 }
77 77
78 void PageTimingMetricsSender::SendNow() { 78 void PageTimingMetricsSender::SendNow() {
79 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated( 79 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated(
80 routing_id_, last_timing_, metadata_)); 80 routing_id_, *last_timing_, metadata_));
81 } 81 }
82 82
83 } // namespace page_load_metrics 83 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698