components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc - Issue 2874663002: [subresource_filter] s/ShouldSuppressActivation/OnPageActivationComputed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

Issue 2874663002: [subresource_filter] s/ShouldSuppressActivation/OnPageActivationComputed (Closed)

Patch Set: engedy review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc ('K') | « components/subresource_filter/content/browser/subresource_filter_client.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

diff --git a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc b/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

index 6c53c62c38ed5b8da2869541053eb754698094a8..c5b34cb8d05d1db91fd9917c3c9ce572f414c3b8 100644

--- a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

+++ b/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc

@@ -79,7 +79,8 @@ class MockSubresourceFilterClient

~MockSubresourceFilterClient() override = default;

MOCK_METHOD1(ToggleNotificationVisibility, void(bool));

- MOCK_METHOD1(ShouldSuppressActivation, bool(content::NavigationHandle*));

+ MOCK_METHOD2(OnPageActivationComputed,

+ bool(content::NavigationHandle*, bool));

MOCK_METHOD1(WhitelistByContentSettings, void(const GURL&));

MOCK_METHOD1(WhitelistInCurrentWebContents, void(const GURL&));

MOCK_METHOD0(GetRulesetDealer, VerifiedRulesetDealer::Handle*());