chrome/browser/subresource_filter/chrome_subresource_filter_client.h - Issue 2874663002: [subresource_filter] s/ShouldSuppressActivation/OnPageActivationComputed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/subresource_filter/chrome_subresource_filter_client.h

Issue 2874663002: [subresource_filter] s/ShouldSuppressActivation/OnPageActivationComputed (Closed)

Patch Set: engedy review Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/subresource_filter/chrome_subresource_filter_client.cc » ('j') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/subresource_filter/chrome_subresource_filter_client.h

diff --git a/chrome/browser/subresource_filter/chrome_subresource_filter_client.h b/chrome/browser/subresource_filter/chrome_subresource_filter_client.h

index 8e47d342c9d39f5596ad3f03c25ccf30e1a9b935..8354295f12ddda2da89a48d9c3a04f97d1477fef 100644

--- a/chrome/browser/subresource_filter/chrome_subresource_filter_client.h

+++ b/chrome/browser/subresource_filter/chrome_subresource_filter_client.h

@@ -92,8 +92,8 @@ class ChromeSubresourceFilterClient

// SubresourceFilterClient:

void ToggleNotificationVisibility(bool visibility) override;

- bool ShouldSuppressActivation(

- content::NavigationHandle* navigation_handle) override;

+ bool OnPageActivationComputed(content::NavigationHandle* navigation_handle,

+ bool activated) override;

void WhitelistByContentSettings(const GURL& url) override;

void WhitelistInCurrentWebContents(const GURL& url) override;

subresource_filter::VerifiedRulesetDealer::Handle* GetRulesetDealer()