Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

Issue 2874663002: [subresource_filter] s/ShouldSuppressActivation/OnPageActivationComputed (Closed)
Patch Set: count() Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
index 814d137987e1f613c2f1928a601738c7e278dfc4..22ce9ea0bf9d21f2ef13e05b49c92fa54a075d9c 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc
@@ -189,10 +189,11 @@ class MockSubresourceFilterClient : public SubresourceFilterClient {
~MockSubresourceFilterClient() override = default;
- bool ShouldSuppressActivation(content::NavigationHandle* handle) override {
- return handle->IsInMainFrame() &&
- whitelisted_hosts_.find(handle->GetURL().host()) !=
- whitelisted_hosts_.end();
+ bool OnPageActivationComputed(content::NavigationHandle* handle,
+ bool activated) override {
+ DCHECK(handle->IsInMainFrame());
+ return activated && whitelisted_hosts_.find(handle->GetURL().host()) !=
+ whitelisted_hosts_.end();
shivanisha 2017/05/10 18:43:18 Did you mean to move back to count()?
Charlie Harrison 2017/05/10 18:55:21 Oh, I just forgot to update the test only implemen
Charlie Harrison 2017/05/10 18:57:32 Done. OK landing now :)
}
void WhitelistByContentSettings(const GURL& url) override {}

Powered by Google App Engine
This is Rietveld 408576698