Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Unified Diff: content/browser/histogram_internals_request_job.h

Issue 2874623002: Implement chrome://histograms with network service. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/histogram_internals_request_job.h
diff --git a/content/browser/histogram_internals_request_job.h b/content/browser/histogram_internals_request_job.h
index 475188d7c3afa5609f50cf39dfc4f4118723bd9c..08c77616d2c650bc443561446ca68a0a9dfbcefa 100644
--- a/content/browser/histogram_internals_request_job.h
+++ b/content/browser/histogram_internals_request_job.h
@@ -10,6 +10,7 @@
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
#include "net/url_request/url_request_simple_job.h"
+#include "url/gurl.h"
namespace content {
@@ -25,6 +26,11 @@ class HistogramInternalsRequestJob : public net::URLRequestSimpleJob {
std::string* data,
const net::CompletionCallback& callback) const override;
+ // Generates the HTML for chrome://histograms.
+ // base::StatisticsRecorder::ImportProvidedHistograms must have been called
+ // on the UI thread first.
+ static std::string GenerateHTML(const GURL& url);
+
private:
~HistogramInternalsRequestJob() override;
@@ -32,7 +38,7 @@ class HistogramInternalsRequestJob : public net::URLRequestSimpleJob {
void StartUrlRequest();
// The string to select histograms which have |path_| as a substring.
yzshen1 2017/05/10 15:13:43 Please update the comment.
jam 2017/05/10 15:29:58 Done.
- std::string path_;
+ GURL url_;
base::WeakPtrFactory<HistogramInternalsRequestJob> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698