chrome/browser/ui/views/omnibox/omnibox_result_view.cc - Issue 2874593002: Omnibox UI Experiments: Clean up naming for Vertical Margin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Issue 2874593002: Omnibox UI Experiments: Clean up naming for Vertical Margin (Closed)

Patch Set: change back misspelling Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_result_view.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

index 87902bb5f48a65fae90d1cdadc908cd4206cfee3..ac562ab5135967e8f350a60a11b89818e3dee888 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

@@ -727,8 +727,8 @@ int OmniboxResultView::GetVerticalMargin() const {

// adequately sized touch target.

using Md = ui::MaterialDesignController;

const int kIconVerticalPad = base::GetFieldTrialParamByFeatureAsInt(

- omnibox::kUIExperiments,

- OmniboxFieldTrial::kUIExperimentsVerticalMarginParam,

+ omnibox::kUIExperimentVerticalMargin,

+ OmniboxFieldTrial::kUIVerticalMarginParam,

Md::GetMode() == Md::MATERIAL_HYBRID ? 8 : 4);

const int min_height = LocationBarView::kIconWidth + 2 * kIconVerticalPad;

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/omnibox/browser/omnibox_field_trial.h » ('j') | no next file with comments »