Omnibox UI Experiments: Clean up naming for Vertical Margin

components/omnibox/browser/omnibox_field_trial.cc

Index: components/omnibox/browser/omnibox_field_trial.cc
diff --git a/components/omnibox/browser/omnibox_field_trial.cc b/components/omnibox/browser/omnibox_field_trial.cc
index fe37056d252e74ee5315aacd73316aa2a61a6ad7..4bef122df76fbf997b550123a981f3d42b9cc8d1 100644
--- a/components/omnibox/browser/omnibox_field_trial.cc
+++ b/components/omnibox/browser/omnibox_field_trial.cc
@@ -80,9 +80,9 @@ const base::Feature kZeroSuggestSwapTitleAndUrl{
 const base::Feature kDisplayTitleForCurrentUrl{
     "OmniboxDisplayTitleForCurrentUrl", base::FEATURE_DISABLED_BY_DEFAULT};
 
-// Feature used for UI experiments.
-const base::Feature kUIExperiments{"OmniboxUIExperiments",
-                                   base::FEATURE_DISABLED_BY_DEFAULT};
+// Feature used for the Vertical Margin UI experiment.

[Peter Kasting, 2017/05/10 20:26:34]

Nit: Maybe wouldn't capitalize V, M?

[tommycli, 2017/05/10 20:30:39]

Done.

+const base::Feature kUIExperimentVerticalMargin{
+    "OmniboxUIExperimentVerticalMargin", base::FEATURE_DISABLED_BY_DEFAULT};

[Peter Kasting, 2017/05/10 20:26:34]

We're not very consistent about whether to put "Omnibox" in front of these
things.  It seems like we should be.  Can we just always remove it?

[tommycli, 2017/05/10 20:30:39]

I would probably advocate keeping it, since this string also appears in
enums.xml, where there's no context. If it just said "ExperimentVerticalMargin"
it might be confusing.

[Peter Kasting, 2017/05/10 20:31:42]

Should we add it to the things that don't have it then?  Or is my desire for
consistency misguided here?

[tommycli, 2017/05/10 20:35:54]

I think that would be a good thing. But would that mess up finch configs? It
would probably also mess up existing histogram data for experiments that have
already been running.

In either case probably a separate CL right?

[Peter Kasting, 2017/05/10 20:43:51]

Maybe?  I dunno.  My job as reviewer is to lob the hard questions at you, then
run.  :D

 
 }  // namespace omnibox
 
@@ -740,8 +740,7 @@ const char
     OmniboxFieldTrial::kZeroSuggestRedirectToChromeAdditionalFieldsParam[] =
         "ZeroSuggestRedirectToChromeAdditionalFields";
 
-const char OmniboxFieldTrial::kUIExperimentsVerticalMarginParam[] =
-    "UIExperimentsVerticalMargin";
+const char OmniboxFieldTrial::kUIVerticalMarginParam[] = "UIVerticalMargin";
 
 // static
 int OmniboxFieldTrial::kDefaultMinimumTimeBetweenSuggestQueriesMs = 100;