Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2874593002: Omnibox UI Experiments: Clean up naming for Vertical Margin (Closed)
Patch Set: change back misspelling Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_result_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 949 matching lines...) Expand 10 before | Expand all | Expand 10 after
960 {flags_ui::kGenericExperimentChoiceDisabled, "", ""}, 960 {flags_ui::kGenericExperimentChoiceDisabled, "", ""},
961 {flag_descriptions::kEnableHeapProfilingModePseudo, 961 {flag_descriptions::kEnableHeapProfilingModePseudo,
962 switches::kEnableHeapProfiling, switches::kEnableHeapProfilingModePseudo}, 962 switches::kEnableHeapProfiling, switches::kEnableHeapProfilingModePseudo},
963 {flag_descriptions::kEnableHeapProfilingModeNative, 963 {flag_descriptions::kEnableHeapProfilingModeNative,
964 switches::kEnableHeapProfiling, switches::kEnableHeapProfilingModeNative}, 964 switches::kEnableHeapProfiling, switches::kEnableHeapProfilingModeNative},
965 {flag_descriptions::kEnableHeapProfilingTaskProfiler, 965 {flag_descriptions::kEnableHeapProfilingTaskProfiler,
966 switches::kEnableHeapProfiling, 966 switches::kEnableHeapProfiling,
967 switches::kEnableHeapProfilingTaskProfiler}}; 967 switches::kEnableHeapProfilingTaskProfiler}};
968 968
969 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin4px[] = { 969 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin4px[] = {
970 {OmniboxFieldTrial::kUIExperimentsVerticalMarginParam, "4"}}; 970 {OmniboxFieldTrial::kUIVerticalMarginParam, "4"}};
971 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin8px[] = { 971 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin8px[] = {
972 {OmniboxFieldTrial::kUIExperimentsVerticalMarginParam, "8"}}; 972 {OmniboxFieldTrial::kUIVerticalMarginParam, "8"}};
973 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin12px[] = { 973 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin12px[] = {
974 {OmniboxFieldTrial::kUIExperimentsVerticalMarginParam, "12"}}; 974 {OmniboxFieldTrial::kUIVerticalMarginParam, "12"}};
975 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin16px[] = { 975 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin16px[] = {
976 {OmniboxFieldTrial::kUIExperimentsVerticalMarginParam, "16"}}; 976 {OmniboxFieldTrial::kUIVerticalMarginParam, "16"}};
977 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin20px[] = { 977 const FeatureEntry::FeatureParam kOmniboxUIVerticalMargin20px[] = {
978 {OmniboxFieldTrial::kUIExperimentsVerticalMarginParam, "20"}}; 978 {OmniboxFieldTrial::kUIVerticalMarginParam, "20"}};
979 979
980 const FeatureEntry::FeatureVariation kOmniboxUIVerticalMarginVariations[] = { 980 const FeatureEntry::FeatureVariation kOmniboxUIVerticalMarginVariations[] = {
981 {"4px vertical margin", kOmniboxUIVerticalMargin4px, 981 {"4px vertical margin", kOmniboxUIVerticalMargin4px,
982 arraysize(kOmniboxUIVerticalMargin4px), nullptr}, 982 arraysize(kOmniboxUIVerticalMargin4px), nullptr},
983 {"8px vertical margin", kOmniboxUIVerticalMargin8px, 983 {"8px vertical margin", kOmniboxUIVerticalMargin8px,
984 arraysize(kOmniboxUIVerticalMargin8px), nullptr}, 984 arraysize(kOmniboxUIVerticalMargin8px), nullptr},
985 {"12px vertical margin", kOmniboxUIVerticalMargin12px, 985 {"12px vertical margin", kOmniboxUIVerticalMargin12px,
986 arraysize(kOmniboxUIVerticalMargin12px), nullptr}, 986 arraysize(kOmniboxUIVerticalMargin12px), nullptr},
987 {"16px vertical margin", kOmniboxUIVerticalMargin16px, 987 {"16px vertical margin", kOmniboxUIVerticalMargin16px,
988 arraysize(kOmniboxUIVerticalMargin16px), nullptr}, 988 arraysize(kOmniboxUIVerticalMargin16px), nullptr},
(...skipping 1867 matching lines...) Expand 10 before | Expand all | Expand 10 after
2856 2856
2857 #if defined(TOOLKIT_VIEWS) || (defined(OS_MACOSX) && !defined(OS_IOS)) 2857 #if defined(TOOLKIT_VIEWS) || (defined(OS_MACOSX) && !defined(OS_IOS))
2858 {"show-cert-link", flag_descriptions::kShowCertLinkOnPageInfoName, 2858 {"show-cert-link", flag_descriptions::kShowCertLinkOnPageInfoName,
2859 flag_descriptions::kShowCertLinkOnPageInfoDescription, kOsDesktop, 2859 flag_descriptions::kShowCertLinkOnPageInfoDescription, kOsDesktop,
2860 SINGLE_VALUE_TYPE(switches::kShowCertLink)}, 2860 SINGLE_VALUE_TYPE(switches::kShowCertLink)},
2861 #endif 2861 #endif
2862 2862
2863 {"omnibox-ui-vertical-margin", 2863 {"omnibox-ui-vertical-margin",
2864 flag_descriptions::kOmniboxUIVerticalMarginName, 2864 flag_descriptions::kOmniboxUIVerticalMarginName,
2865 flag_descriptions::kOmniboxUIVerticalMarginDescription, kOsDesktop, 2865 flag_descriptions::kOmniboxUIVerticalMarginDescription, kOsDesktop,
2866 FEATURE_WITH_PARAMS_VALUE_TYPE(omnibox::kUIExperiments, 2866 FEATURE_WITH_PARAMS_VALUE_TYPE(omnibox::kUIExperimentVerticalMargin,
2867 kOmniboxUIVerticalMarginVariations, 2867 kOmniboxUIVerticalMarginVariations,
2868 "OmniboxUIVerticalMarginVariations")}, 2868 "OmniboxUIVerticalMarginVariations")},
2869 2869
2870 {"use-suggestions-even-if-few", 2870 {"use-suggestions-even-if-few",
2871 flag_descriptions::kUseSuggestionsEvenIfFewFeatureName, 2871 flag_descriptions::kUseSuggestionsEvenIfFewFeatureName,
2872 flag_descriptions::kUseSuggestionsEvenIfFewFeatureDescription, kOsAll, 2872 flag_descriptions::kUseSuggestionsEvenIfFewFeatureDescription, kOsAll,
2873 FEATURE_VALUE_TYPE(suggestions::kUseSuggestionsEvenIfFewFeature)}, 2873 FEATURE_VALUE_TYPE(suggestions::kUseSuggestionsEvenIfFewFeature)},
2874 2874
2875 {"enable-location-hard-reload", flag_descriptions::kLocationHardReloadName, 2875 {"enable-location-hard-reload", flag_descriptions::kLocationHardReloadName,
2876 flag_descriptions::kLocationHardReloadDescription, kOsAll, 2876 flag_descriptions::kLocationHardReloadDescription, kOsAll,
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
3099 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3099 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3100 3100
3101 const FeatureEntry* GetFeatureEntries(size_t* count) { 3101 const FeatureEntry* GetFeatureEntries(size_t* count) {
3102 *count = arraysize(kFeatureEntries); 3102 *count = arraysize(kFeatureEntries);
3103 return kFeatureEntries; 3103 return kFeatureEntries;
3104 } 3104 }
3105 3105
3106 } // namespace testing 3106 } // namespace testing
3107 3107
3108 } // namespace about_flags 3108 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/omnibox/omnibox_result_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698