Refactor ARC OOM handler code

chrome/browser/memory/tab_manager_delegate_chromeos_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/memory/tab_manager_delegate_chromeos.h"
 
 #include <algorithm>
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 215 matching lines @@
 
   std::vector<arc::ArcProcess> arc_processes;
   arc_processes.emplace_back(1, 10, "focused", arc::mojom::ProcessState::TOP,
                              kIsFocused, 100);
   arc_processes.emplace_back(2, 20, "visible1", arc::mojom::ProcessState::TOP,
                              kNotFocused, 200);
   arc_processes.emplace_back(
       3, 30, "service", arc::mojom::ProcessState::SERVICE, kNotFocused, 500);
   arc_processes.emplace_back(4, 40, "visible2", arc::mojom::ProcessState::TOP,
                              kNotFocused, 150);
+  arc_processes.emplace_back(5, 50, "persistent",
+                             arc::mojom::ProcessState::PERSISTENT, kNotFocused,
+                             600);
+  arc_processes.emplace_back(6, 60, "persistent_ui",
+                             arc::mojom::ProcessState::PERSISTENT_UI,
+                             kNotFocused, 700);
 
   TabStats tab1, tab2, tab3, tab4, tab5;
   tab1.is_pinned = true;
   tab1.renderer_handle = 11;
 
   tab2.is_internal_page = true;
   tab2.renderer_handle = 11;
 
   tab3.is_pinned = true;
   tab3.is_media = true;
   tab3.renderer_handle = 12;
 
   tab4.is_media = true;
   tab4.renderer_handle = 12;
 
   tab5.is_app = true;
   tab5.renderer_handle = 12;
   TabStatsList tab_list = {tab1, tab2, tab3, tab4, tab5};
 
-  // Sorted order:
-  // app "focused"     pid: 10
-  // app "visible1"    pid: 20
-  // app "visible2"    pid: 40
-  // tab3              pid: 12
-  // tab4              pid: 12
-  // tab1              pid: 11
-  // tab5              pid: 12
-  // tab2              pid: 11
-  // app "service"     pid: 30
+  // Sorted order (by GetSortedCandidates):
+  // app "focused"       pid: 10
+  // app "persistent"    pid: 50
+  // app "persistent_ui" pid: 60
+  // app "visible1"      pid: 20
+  // app "visible2"      pid: 40
+  // tab3                pid: 12
+  // tab4                pid: 12
+  // tab1                pid: 11
+  // tab5                pid: 12
+  // tab2                pid: 11
+  // app "service"       pid: 30
   tab_manager_delegate.AdjustOomPrioritiesImpl(tab_list, arc_processes);
   auto& oom_score_map = tab_manager_delegate.oom_score_map_;
 
-  EXPECT_EQ(6U, oom_score_map.size());
+  // 6 PIDs for apps + 2 PIDs for tabs.
+  EXPECT_EQ(6U + 2U, oom_score_map.size());
+
+  // Non-killable part. AdjustOomPrioritiesImpl() does make a focused app/tab
+  // kernel-killable, but does not do that for PERSISTENT and PERSISTENT_UI
+  // apps.
+  EXPECT_EQ(TabManagerDelegate::kLowestOomScore, oom_score_map[50]);
+  EXPECT_EQ(TabManagerDelegate::kLowestOomScore, oom_score_map[60]);
 
   // Higher priority part.
   EXPECT_EQ(300, oom_score_map[10]);
   EXPECT_EQ(344, oom_score_map[20]);
   EXPECT_EQ(388, oom_score_map[40]);
   EXPECT_EQ(431, oom_score_map[12]);
   EXPECT_EQ(475, oom_score_map[11]);
 
   // Lower priority part.
   EXPECT_EQ(650, oom_score_map[30]);
@@ skipping 82 matching lines @@
   arc_processes.emplace_back(2, 20, "visible1", arc::mojom::ProcessState::TOP,
                              kNotFocused, 200);
   arc_processes.emplace_back(
       3, 30, "service", arc::mojom::ProcessState::SERVICE, kNotFocused, 500);
   arc_processes.emplace_back(4, 40, "visible2",
                              arc::mojom::ProcessState::IMPORTANT_FOREGROUND,
                              kNotFocused, 150);
   arc_processes.emplace_back(5, 50, "not-visible",
                              arc::mojom::ProcessState::IMPORTANT_BACKGROUND,
                              kNotFocused, 300);
+  arc_processes.emplace_back(6, 60, "persistent",
+                             arc::mojom::ProcessState::PERSISTENT, kNotFocused,
+                             400);
 
   TabStats tab1, tab2, tab3, tab4, tab5;
   tab1.is_pinned = true;
   tab1.renderer_handle = 11;
   tab1.tab_contents_id = 1;
 
   tab2.is_internal_page = true;
   tab2.renderer_handle = 11;
   tab2.tab_contents_id = 2;
 
   tab3.is_pinned = true;
   tab3.is_media = true;
   tab3.renderer_handle = 12;
   tab3.tab_contents_id = 3;
 
   tab4.is_media = true;
   tab4.renderer_handle = 12;
   tab4.tab_contents_id = 4;
 
   tab5.is_app = true;
   tab5.renderer_handle = 12;
   tab5.tab_contents_id = 5;
   TabStatsList tab_list = {tab1, tab2, tab3, tab4, tab5};
 
-  // Sorted order:
+  // Sorted order (by GetSortedCandidates):
   // app "focused"     pid: 10  nspid 1
+  // app "persistent"  pid: 60  nspid 6
   // app "visible1"    pid: 20  nspid 2
   // app "visible2"    pid: 40  nspid 4
   // tab3              pid: 12  tab_contents_id 3
   // tab4              pid: 12  tab_contents_id 4
   // tab1              pid: 11  tab_contents_id 1
   // tab5              pid: 12  tab_contents_id 5
   // tab2              pid: 11  tab_contents_id 2
   // app "not-visible" pid: 50  nspid 5
   // app "service"     pid: 30  nspid 3
   memory_stat->SetTargetMemoryToFreeKB(250000);
   // Entities to be killed.
   memory_stat->SetProcessPss(30, 10000);
   memory_stat->SetProcessPss(50, 5000);
   memory_stat->SetProcessPss(11, 200000);
   memory_stat->SetProcessPss(12, 30000);
   // Should not be used.
+  memory_stat->SetProcessPss(60, 500000);
   memory_stat->SetProcessPss(40, 50000);
   memory_stat->SetProcessPss(20, 30000);
   memory_stat->SetProcessPss(10, 100000);
 
   tab_manager_delegate.LowMemoryKillImpl(tab_list, arc_processes);
 
   auto killed_arc_processes = tab_manager_delegate.GetKilledArcProcesses();
   auto killed_tabs = tab_manager_delegate.GetKilledTabs();
 
   // Killed apps and their nspid.
@@ skipping 10 matching lines @@
 
   // Check that killed apps are in the map.
   const TabManagerDelegate::KilledArcProcessesMap& processes_map =
       tab_manager_delegate.recently_killed_arc_processes_;
   EXPECT_EQ(2U, processes_map.size());
   EXPECT_EQ(1U, processes_map.count("service"));
   EXPECT_EQ(1U, processes_map.count("not-visible"));
 }
 
 }  // namespace memory