Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/chromeos/arc/process/arc_process_unittest.cc

Issue 2874543002: Refactor ARC OOM handler code (Closed)
Patch Set: address comments from Cheng-Yu Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« chrome/browser/chromeos/arc/process/arc_process.cc ('K') | « chrome/browser/chromeos/arc/process/arc_process.cc ('k') | chrome/browser/memory/tab_manager_delegate_chromeos.h » ('j') | chrome/browser/memory/tab_manager_delegate_chromeos.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/arc/process/arc_process.h" 5 #include "chrome/browser/chromeos/arc/process/arc_process.h"
6 6
7 #include <assert.h> 7 #include <assert.h>
8 #include <list> 8 #include <list>
9 9
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace arc { 12 namespace arc {
13 13
14 namespace { 14 namespace {
15 15
16 // Tests that ArcProcess objects can be sorted by their priority (higher to 16 // Tests that ArcProcess objects can be sorted by their priority (higher to
17 // lower). This is critical for the OOM handler to work correctly. 17 // lower). This is critical for the OOM handler to work correctly.
18 TEST(ArcProcess, TestSorting) { 18 TEST(ArcProcess, TestSorting) {
19 constexpr int64_t kNow = 1234567890; 19 constexpr int64_t kNow = 1234567890;
20 20
21 std::list<ArcProcess> processes; // use list<> for emplace_front. 21 std::list<ArcProcess> processes; // use list<> for emplace_front.
22 processes.emplace_back(0, 0, "process 0", mojom::ProcessState::PERSISTENT, 22 processes.emplace_back(0, 0, "process 0", mojom::ProcessState::PERSISTENT,
23 false /* is_foreground */, kNow + 1); 23 false /* is_focused */, kNow + 1);
24 processes.emplace_front(1, 1, "process 1", mojom::ProcessState::PERSISTENT, 24 processes.emplace_front(1, 1, "process 1", mojom::ProcessState::PERSISTENT,
25 false, kNow); 25 false, kNow);
26 processes.emplace_back(2, 2, "process 2", mojom::ProcessState::LAST_ACTIVITY, 26 processes.emplace_back(2, 2, "process 2", mojom::ProcessState::LAST_ACTIVITY,
27 false, kNow); 27 false, kNow);
28 processes.emplace_front(3, 3, "process 3", mojom::ProcessState::LAST_ACTIVITY, 28 processes.emplace_front(3, 3, "process 3", mojom::ProcessState::LAST_ACTIVITY,
29 false, kNow + 1); 29 false, kNow + 1);
30 processes.emplace_back(4, 4, "process 4", mojom::ProcessState::CACHED_EMPTY, 30 processes.emplace_back(4, 4, "process 4", mojom::ProcessState::CACHED_EMPTY,
31 false, kNow + 1); 31 false, kNow + 1);
32 processes.emplace_front(5, 5, "process 5", mojom::ProcessState::CACHED_EMPTY, 32 processes.emplace_front(5, 5, "process 5", mojom::ProcessState::CACHED_EMPTY,
33 false, kNow); 33 false, kNow);
(...skipping 16 matching lines...) Expand all
50 EXPECT_EQ(3, it->pid()); 50 EXPECT_EQ(3, it->pid());
51 ++it; 51 ++it;
52 EXPECT_EQ(2, it->pid()); 52 EXPECT_EQ(2, it->pid());
53 ++it; 53 ++it;
54 // Same, 4 should have higher priority. 54 // Same, 4 should have higher priority.
55 EXPECT_EQ(4, it->pid()); 55 EXPECT_EQ(4, it->pid());
56 ++it; 56 ++it;
57 EXPECT_EQ(5, it->pid()); 57 EXPECT_EQ(5, it->pid());
58 } 58 }
59 59
60 TEST(ArcProcess, TestIsImportant) {
61 constexpr bool kIsNotFocused = false;
62
63 // Processes up to IMPORTANT_FOREGROUND are considered important.
64 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::PERSISTENT,
65 kIsNotFocused, 0)
66 .IsImportant());
67 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::PERSISTENT_UI,
68 kIsNotFocused, 0)
69 .IsImportant());
70 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::TOP, true, 0)
71 .IsImportant());
72 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::TOP, false, 0)
73 .IsImportant());
74 EXPECT_TRUE(ArcProcess(0, 0, "process",
75 mojom::ProcessState::BOUND_FOREGROUND_SERVICE,
76 kIsNotFocused, 0)
77 .IsImportant());
78 EXPECT_TRUE(ArcProcess(0, 0, "process",
79 mojom::ProcessState::FOREGROUND_SERVICE, kIsNotFocused,
80 0)
81 .IsImportant());
82 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::TOP_SLEEPING,
83 kIsNotFocused, 0)
84 .IsImportant());
85 EXPECT_TRUE(ArcProcess(0, 0, "process",
86 mojom::ProcessState::IMPORTANT_FOREGROUND,
87 kIsNotFocused, 0)
88 .IsImportant());
89
90 // Others are not important.
91 EXPECT_FALSE(ArcProcess(0, 0, "process",
92 mojom::ProcessState::IMPORTANT_BACKGROUND,
93 kIsNotFocused, 0)
94 .IsImportant());
95 EXPECT_FALSE(
96 ArcProcess(0, 0, "process", mojom::ProcessState::BACKUP, kIsNotFocused, 0)
97 .IsImportant());
98 EXPECT_FALSE(ArcProcess(0, 0, "process", mojom::ProcessState::HEAVY_WEIGHT,
99 kIsNotFocused, 0)
100 .IsImportant());
101 EXPECT_FALSE(ArcProcess(0, 0, "process", mojom::ProcessState::SERVICE,
102 kIsNotFocused, 0)
103 .IsImportant());
104 EXPECT_FALSE(ArcProcess(0, 0, "process", mojom::ProcessState::RECEIVER,
105 kIsNotFocused, 0)
106 .IsImportant());
107 EXPECT_FALSE(
108 ArcProcess(0, 0, "process", mojom::ProcessState::HOME, kIsNotFocused, 0)
109 .IsImportant());
110 EXPECT_FALSE(ArcProcess(0, 0, "process", mojom::ProcessState::LAST_ACTIVITY,
111 kIsNotFocused, 0)
112 .IsImportant());
113 EXPECT_FALSE(ArcProcess(0, 0, "process", mojom::ProcessState::CACHED_ACTIVITY,
114 kIsNotFocused, 0)
115 .IsImportant());
116 EXPECT_FALSE(ArcProcess(0, 0, "process",
117 mojom::ProcessState::CACHED_ACTIVITY_CLIENT,
118 kIsNotFocused, 0)
119 .IsImportant());
120 EXPECT_FALSE(ArcProcess(0, 0, "process", mojom::ProcessState::CACHED_EMPTY,
121 kIsNotFocused, 0)
122 .IsImportant());
123
124 // Exceptions: the function always returns true ignoring ProcessState for our
125 // HOME process.
126 EXPECT_TRUE(ArcProcess(0, 0, "org.chromium.arc.home",
127 mojom::ProcessState::TOP, kIsNotFocused, 0)
128 .IsImportant());
129 EXPECT_TRUE(ArcProcess(0, 0, "org.chromium.arc.home",
130 mojom::ProcessState::HOME, kIsNotFocused, 0)
131 .IsImportant());
132 }
133
134 TEST(ArcProcess, TestIsKernelKillable) {
135 constexpr bool kIsNotFocused = false;
136
137 // Only PERSISITENT* processes are protected from the kernel OOM killer.
138 EXPECT_FALSE(ArcProcess(0, 0, "process", mojom::ProcessState::PERSISTENT,
139 kIsNotFocused, 0)
140 .IsKernelKillable());
141 EXPECT_FALSE(ArcProcess(0, 0, "process", mojom::ProcessState::PERSISTENT_UI,
142 kIsNotFocused, 0)
143 .IsKernelKillable());
144
145 // Both TOP+focused and TOP apps are still kernel-killable.
146 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::TOP, true, 0)
147 .IsKernelKillable());
148 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::TOP, false, 0)
149 .IsKernelKillable());
150
151 // Others are kernel-killable.
152 EXPECT_TRUE(ArcProcess(0, 0, "process",
153 mojom::ProcessState::BOUND_FOREGROUND_SERVICE,
154 kIsNotFocused, 0)
155 .IsKernelKillable());
156 EXPECT_TRUE(ArcProcess(0, 0, "process",
157 mojom::ProcessState::FOREGROUND_SERVICE, kIsNotFocused,
158 0)
159 .IsKernelKillable());
160 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::TOP_SLEEPING,
161 kIsNotFocused, 0)
162 .IsKernelKillable());
163 EXPECT_TRUE(ArcProcess(0, 0, "process",
164 mojom::ProcessState::IMPORTANT_FOREGROUND,
165 kIsNotFocused, 0)
166 .IsKernelKillable());
167 EXPECT_TRUE(ArcProcess(0, 0, "process",
168 mojom::ProcessState::IMPORTANT_BACKGROUND,
169 kIsNotFocused, 0)
170 .IsKernelKillable());
171 EXPECT_TRUE(
172 ArcProcess(0, 0, "process", mojom::ProcessState::BACKUP, kIsNotFocused, 0)
173 .IsKernelKillable());
174 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::HEAVY_WEIGHT,
175 kIsNotFocused, 0)
176 .IsKernelKillable());
177 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::SERVICE,
178 kIsNotFocused, 0)
179 .IsKernelKillable());
180 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::RECEIVER,
181 kIsNotFocused, 0)
182 .IsKernelKillable());
183 EXPECT_TRUE(
184 ArcProcess(0, 0, "process", mojom::ProcessState::HOME, kIsNotFocused, 0)
185 .IsKernelKillable());
186 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::LAST_ACTIVITY,
187 kIsNotFocused, 0)
188 .IsKernelKillable());
189 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::CACHED_ACTIVITY,
190 kIsNotFocused, 0)
191 .IsKernelKillable());
192 EXPECT_TRUE(ArcProcess(0, 0, "process",
193 mojom::ProcessState::CACHED_ACTIVITY_CLIENT,
194 kIsNotFocused, 0)
195 .IsKernelKillable());
196 EXPECT_TRUE(ArcProcess(0, 0, "process", mojom::ProcessState::CACHED_EMPTY,
197 kIsNotFocused, 0)
198 .IsKernelKillable());
199
200 // Exceptions: the function always returns false ignoring ProcessState for our
201 // HOME process.
202 EXPECT_FALSE(ArcProcess(0, 0, "org.chromium.arc.home",
203 mojom::ProcessState::TOP, kIsNotFocused, 0)
204 .IsKernelKillable());
205 EXPECT_FALSE(ArcProcess(0, 0, "org.chromium.arc.home",
206 mojom::ProcessState::HOME, kIsNotFocused, 0)
207 .IsKernelKillable());
208 }
209
60 } // namespace 210 } // namespace
61 211
62 } // namespace arc 212 } // namespace arc
OLDNEW
« chrome/browser/chromeos/arc/process/arc_process.cc ('K') | « chrome/browser/chromeos/arc/process/arc_process.cc ('k') | chrome/browser/memory/tab_manager_delegate_chromeos.h » ('j') | chrome/browser/memory/tab_manager_delegate_chromeos.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698