Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: chrome/browser/chromeos/arc/process/arc_process.h

Issue 2874543002: Refactor ARC OOM handler code (Closed)
Patch Set: address comments from Cheng-Yu Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_ARC_PROCESS_ARC_PROCESS_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_ARC_PROCESS_ARC_PROCESS_H_
6 #define CHROME_BROWSER_CHROMEOS_ARC_PROCESS_ARC_PROCESS_H_ 6 #define CHROME_BROWSER_CHROMEOS_ARC_PROCESS_ARC_PROCESS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 21 matching lines...) Expand all
32 32
33 base::ProcessId nspid() const { return nspid_; } 33 base::ProcessId nspid() const { return nspid_; }
34 base::ProcessId pid() const { return pid_; } 34 base::ProcessId pid() const { return pid_; }
35 const std::string& process_name() const { return process_name_; } 35 const std::string& process_name() const { return process_name_; }
36 mojom::ProcessState process_state() const { return process_state_; } 36 mojom::ProcessState process_state() const { return process_state_; }
37 bool is_focused() const { return is_focused_; } 37 bool is_focused() const { return is_focused_; }
38 int64_t last_activity_time() const { return last_activity_time_; } 38 int64_t last_activity_time() const { return last_activity_time_; }
39 std::vector<std::string>& packages() { return packages_; } 39 std::vector<std::string>& packages() { return packages_; }
40 const std::vector<std::string>& packages() const { return packages_; } 40 const std::vector<std::string>& packages() const { return packages_; }
41 41
42 // Returns true if the process is important and should be protected more
43 // from OOM kills than other processes.
44 // TODO(cylee|yusukes): Check what stock Android does for handling OOM and
45 // modify this function as needed (crbug.com/719537).
46 bool IsImportant() const;
47
48 // Returns true if it is okay for the kernel OOM killer to kill the process.
49 // TODO(cylee|yusukes): Consider removing this function. Having only
50 // IsImportant() might be good enough.
51 bool IsKernelKillable() const;
52
42 private: 53 private:
43 base::ProcessId nspid_; 54 base::ProcessId nspid_;
44 base::ProcessId pid_; 55 base::ProcessId pid_;
45 std::string process_name_; 56 std::string process_name_;
46 mojom::ProcessState process_state_; 57 mojom::ProcessState process_state_;
47 // If the Android app is the focused window. 58 // If the Android app is the focused window.
48 bool is_focused_; 59 bool is_focused_;
49 // A monotonic timer recording the last time this process was active. 60 // A monotonic timer recording the last time this process was active.
50 // Milliseconds since Android boot. This info is passed from Android 61 // Milliseconds since Android boot. This info is passed from Android
51 // ActivityManagerService via IPC. 62 // ActivityManagerService via IPC.
52 int64_t last_activity_time_; 63 int64_t last_activity_time_;
53 std::vector<std::string> packages_; 64 std::vector<std::string> packages_;
54 65
55 DISALLOW_COPY_AND_ASSIGN(ArcProcess); 66 DISALLOW_COPY_AND_ASSIGN(ArcProcess);
56 }; 67 };
57 68
58 } // namespace arc 69 } // namespace arc
59 70
60 #endif // CHROME_BROWSER_CHROMEOS_ARC_PROCESS_ARC_PROCESS_H_ 71 #endif // CHROME_BROWSER_CHROMEOS_ARC_PROCESS_ARC_PROCESS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/arc/process/arc_process.cc » ('j') | chrome/browser/chromeos/arc/process/arc_process.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698