Make ARC's intent picker use the buttons insets.

chrome/browser/ui/views/intent_picker_bubble_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/intent_picker_bubble_view.h"
 
 #include "base/bind.h"
 #include "base/i18n/rtl.h"
 #include "base/logging.h"
 #include "base/strings/string_piece.h"
@@ skipping 90 matching lines @@
                          arc::ArcNavigationThrottle::CloseReason::ERROR);
     return;
   }
   BrowserView* browser_view = BrowserView::GetBrowserViewForBrowser(browser);
   IntentPickerBubbleView* delegate =
       new IntentPickerBubbleView(app_info, intent_picker_cb, web_contents);
   delegate->set_margins(gfx::Insets());
   delegate->set_parent_window(browser_view->GetNativeWindow());
   views::Widget* widget =
       views::BubbleDialogDelegateView::CreateBubble(delegate);
   delegate->GetDialogClientView()->set_button_row_insets(

[sky, 2017/05/10 15:27:02]

Can this be moved above line 109 such that 113 is not necessary? Otherwise I
think set_button_row_insets sure become SetButtonRowInsets() and it should force
a layout. In other words you shouldn't have to manually call
UpdateDialogButtons.

[djacobo, 2017/05/10 18:14:20]

I don't think that's possible since CreateBubble calls Init, so before that
everything GetDialogClientView is still not constructed, right? I did the
suggested experiment and the Browser crashes while trying to start the picker.

       gfx::Insets(kDialogDelegateInsets));
+  delegate->GetDialogClientView()->UpdateDialogButtons();
 
   delegate->SetArrowPaintType(views::BubbleBorder::PAINT_NONE);
   delegate->SetAlignment(views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE);
 
   // Using the TopContainerBoundsInScreen Rect to specify an anchor for the the
   // UI. Rect allow us to set the coordinates(x,y), the width and height for the
   // new Rectangle.
   delegate->SetAnchorRect(
       gfx::Rect(browser_view->GetTopContainerBoundsInScreen().x(),
                 browser_view->GetTopContainerBoundsInScreen().y(),
@@ skipping 215 matching lines @@
     size_t index) {
   return GetIntentPickerLabelButtonAt(index)->GetTargetInkDropState();
 }
 
 void IntentPickerBubbleView::PressButtonForTesting(size_t index,
                                                    const ui::Event& event) {
   views::Button* button =
       static_cast<views::Button*>(GetIntentPickerLabelButtonAt(index));
   ButtonPressed(button, event);
 }