src/crankshaft/hydrogen.cc - Issue 2874453002: [turbofan] Boost performance of Array.prototype.shift by 4x.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2874453002: [turbofan] Boost performance of Array.prototype.shift by 4x. (Closed)

Patch Set: Cosmetic fixes. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index 78e0718c8d93250766fa79468d393b80b7620dfb..97b9263b3bacb0136f83d91dbcdfd404f6083a65 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -8581,7 +8581,7 @@ bool HOptimizedGraphBuilder::TryInlineBuiltinMethodCall(

Handle<JSObject>::null(), true);

// Threshold for fast inlined Array.shift().

- HConstant* inline_threshold = Add<HConstant>(static_cast<int32_t>(16));

+ HConstant* inline_threshold = Add<HConstant>(JSArray::kMaxCopyElements);

Drop(args_count_no_receiver);

HValue* result;

« no previous file with comments | « src/compiler/js-builtin-reducer.cc ('k') | src/objects.h » ('j') | no next file with comments »