Fix/Disable ffmpeg Media Tests on Android

media/filters/ffmpeg_video_decoder_unittest.cc

Index: media/filters/ffmpeg_video_decoder_unittest.cc
diff --git a/media/filters/ffmpeg_video_decoder_unittest.cc b/media/filters/ffmpeg_video_decoder_unittest.cc
index 72ca256ec53f971706f3f983ae182ff9cc2773e1..dfed4d9166dd7dc63ac32213c187aae180f2500c 100644
--- a/media/filters/ffmpeg_video_decoder_unittest.cc
+++ b/media/filters/ffmpeg_video_decoder_unittest.cc
@@ -45,9 +45,15 @@ using ::testing::StrictMock;
 namespace media {
 
 static const VideoPixelFormat kVideoFormat = PIXEL_FORMAT_YV12;
+#if defined(OS_ANDROID)
+static const gfx::Size kCodedSize(320, 180);
+static const gfx::Rect kVisibleRect(320, 180);
+static const gfx::Size kNaturalSize(320, 180);
+#else
 static const gfx::Size kCodedSize(320, 240);
 static const gfx::Rect kVisibleRect(320, 240);
 static const gfx::Size kNaturalSize(320, 240);
+#endif
 
 ACTION_P(ReturnBuffer, buffer) {
   arg0.Run(buffer.get() ? DemuxerStream::kOk : DemuxerStream::kAborted, buffer);
@@ -68,7 +74,11 @@ class FFmpegVideoDecoderTest : public testing::Test {
     // Initialize various test buffers.
     frame_buffer_.reset(new uint8_t[kCodedSize.GetArea()]);
     end_of_stream_buffer_ = DecoderBuffer::CreateEOSBuffer();
+#if defined(OS_ANDROID)

[watk, 2017/05/09 22:08:23]

I would prefer if you defined something like USE_VP8 or USE_H264 at the top of
this file. Based on OS_ANDROID, PROPRIETARY_CODECS,
DISABLE_FFMPEG_VIDEO_DECODERS. And put an #error pragma for the case where
neither are available.

+    i_frame_buffer_ = ReadTestDataFile("h264-320x180-frame-0");
+#else
     i_frame_buffer_ = ReadTestDataFile("vp8-I-frame-320x240");
+#endif
     corrupt_i_frame_buffer_ = ReadTestDataFile("vp8-corrupt-I-frame");
   }
 
@@ -310,6 +320,10 @@ TEST_F(FFmpegVideoDecoderTest, DecodeFrame_DecodeErrorAtEndOfStream) {
             DecodeSingleFrame(corrupt_i_frame_buffer_));
 }
 
+// The following tests depend on vp8 test files, which is not supported on
+// Android by default. Re-enable once appropriate test files have been added.
+// crbug.com/720008
+#if !defined(OS_ANDROID)
 // Decode |i_frame_buffer_| and then a frame with a larger width and verify
 // the output size was adjusted.
 TEST_F(FFmpegVideoDecoderTest, DecodeFrame_LargerWidth) {
@@ -333,6 +347,7 @@ TEST_F(FFmpegVideoDecoderTest, DecodeFrame_LargerHeight) {
 TEST_F(FFmpegVideoDecoderTest, DecodeFrame_SmallerHeight) {
   DecodeIFrameThenTestFile("vp8-I-frame-320x120", 320, 120);
 }
+#endif
 
 // Test resetting when decoder has initialized but not decoded.
 TEST_F(FFmpegVideoDecoderTest, Reset_Initialized) {