Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 287443002: Experimentally re-enable error page browser tests on aura. (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Experimentally re-enable error page browser tests on aura. I haven't been able to reproduce the failures locally or on bots. BUG=109669 TBR=jhawkins@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270754

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -40 lines) Patch
M chrome/browser/errorpage_browsertest.cc View 6 chunks +3 lines, -40 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
mmenke
https://codereview.chromium.org/287443002/diff/1/chrome/browser/errorpage_browsertest.cc File chrome/browser/errorpage_browsertest.cc (right): https://codereview.chromium.org/287443002/diff/1/chrome/browser/errorpage_browsertest.cc#newcode523 chrome/browser/errorpage_browsertest.cc:523: IN_PROC_BROWSER_TEST_F(ErrorPageTest, DNSError_GoBack2) { I enabled these three when investigating ...
6 years, 7 months ago (2014-05-14 15:59:22 UTC) #1
mmenke
ttuttle: Ping!
6 years, 7 months ago (2014-05-15 16:52:35 UTC) #2
Deprecated (see juliatuttle)
lgtm!
6 years, 7 months ago (2014-05-15 17:00:10 UTC) #3
mmenke
jhawkins: TBRing you as a chrome/browser OWNER. Just experimentally re-enabling some tests disabled under Aura ...
6 years, 7 months ago (2014-05-15 17:13:17 UTC) #4
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 7 months ago (2014-05-15 17:13:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/287443002/1
6 years, 7 months ago (2014-05-15 17:16:02 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 18:44:40 UTC) #7
Message was sent while issue was closed.
Change committed as 270754

Powered by Google App Engine
This is Rietveld 408576698