Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: src/compiler/wasm-compiler.cc

Issue 2874403002: [wasm] Swap the implementation of SIMD compare ops using Gt/Ge insteas of Lt/Le (Closed)
Patch Set: Add Todo with bug reference Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/mips64/instruction-selector-mips64.cc ('k') | test/cctest/wasm/test-run-wasm-simd.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/wasm-compiler.cc
diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc
index bb984253017de9addbbc353615b0fb36e91b669a..c188a55d70d62b22481c7b7e281e93365c679bae 100644
--- a/src/compiler/wasm-compiler.cc
+++ b/src/compiler/wasm-compiler.cc
@@ -3296,17 +3296,17 @@ Node* WasmGraphBuilder::SimdOp(wasm::WasmOpcode opcode,
return graph()->NewNode(jsgraph()->machine()->I32x4Ne(), inputs[0],
inputs[1]);
case wasm::kExprI32x4LtS:
- return graph()->NewNode(jsgraph()->machine()->I32x4LtS(), inputs[0],
- inputs[1]);
+ return graph()->NewNode(jsgraph()->machine()->I32x4GtS(), inputs[1],
+ inputs[0]);
case wasm::kExprI32x4LeS:
- return graph()->NewNode(jsgraph()->machine()->I32x4LeS(), inputs[0],
- inputs[1]);
- case wasm::kExprI32x4GtS:
- return graph()->NewNode(jsgraph()->machine()->I32x4LtS(), inputs[1],
+ return graph()->NewNode(jsgraph()->machine()->I32x4GeS(), inputs[1],
inputs[0]);
+ case wasm::kExprI32x4GtS:
+ return graph()->NewNode(jsgraph()->machine()->I32x4GtS(), inputs[0],
+ inputs[1]);
case wasm::kExprI32x4GeS:
- return graph()->NewNode(jsgraph()->machine()->I32x4LeS(), inputs[1],
- inputs[0]);
+ return graph()->NewNode(jsgraph()->machine()->I32x4GeS(), inputs[0],
+ inputs[1]);
case wasm::kExprI32x4UConvertI16x8Low:
return graph()->NewNode(jsgraph()->machine()->I32x4UConvertI16x8Low(),
inputs[0]);
@@ -3320,17 +3320,17 @@ Node* WasmGraphBuilder::SimdOp(wasm::WasmOpcode opcode,
return graph()->NewNode(jsgraph()->machine()->I32x4MaxU(), inputs[0],
inputs[1]);
case wasm::kExprI32x4LtU:
- return graph()->NewNode(jsgraph()->machine()->I32x4LtU(), inputs[0],
- inputs[1]);
+ return graph()->NewNode(jsgraph()->machine()->I32x4GtU(), inputs[1],
+ inputs[0]);
case wasm::kExprI32x4LeU:
- return graph()->NewNode(jsgraph()->machine()->I32x4LeU(), inputs[0],
- inputs[1]);
- case wasm::kExprI32x4GtU:
- return graph()->NewNode(jsgraph()->machine()->I32x4LtU(), inputs[1],
+ return graph()->NewNode(jsgraph()->machine()->I32x4GeU(), inputs[1],
inputs[0]);
+ case wasm::kExprI32x4GtU:
+ return graph()->NewNode(jsgraph()->machine()->I32x4GtU(), inputs[0],
+ inputs[1]);
case wasm::kExprI32x4GeU:
- return graph()->NewNode(jsgraph()->machine()->I32x4LeU(), inputs[1],
- inputs[0]);
+ return graph()->NewNode(jsgraph()->machine()->I32x4GeU(), inputs[0],
+ inputs[1]);
case wasm::kExprI16x8Splat:
return graph()->NewNode(jsgraph()->machine()->I16x8Splat(), inputs[0]);
case wasm::kExprI16x8SConvertI8x16Low:
@@ -3375,17 +3375,17 @@ Node* WasmGraphBuilder::SimdOp(wasm::WasmOpcode opcode,
return graph()->NewNode(jsgraph()->machine()->I16x8Ne(), inputs[0],
inputs[1]);
case wasm::kExprI16x8LtS:
- return graph()->NewNode(jsgraph()->machine()->I16x8LtS(), inputs[0],
- inputs[1]);
+ return graph()->NewNode(jsgraph()->machine()->I16x8GtS(), inputs[1],
+ inputs[0]);
case wasm::kExprI16x8LeS:
- return graph()->NewNode(jsgraph()->machine()->I16x8LeS(), inputs[0],
- inputs[1]);
- case wasm::kExprI16x8GtS:
- return graph()->NewNode(jsgraph()->machine()->I16x8LtS(), inputs[1],
+ return graph()->NewNode(jsgraph()->machine()->I16x8GeS(), inputs[1],
inputs[0]);
+ case wasm::kExprI16x8GtS:
+ return graph()->NewNode(jsgraph()->machine()->I16x8GtS(), inputs[0],
+ inputs[1]);
case wasm::kExprI16x8GeS:
- return graph()->NewNode(jsgraph()->machine()->I16x8LeS(), inputs[1],
- inputs[0]);
+ return graph()->NewNode(jsgraph()->machine()->I16x8GeS(), inputs[0],
+ inputs[1]);
case wasm::kExprI16x8UConvertI8x16Low:
return graph()->NewNode(jsgraph()->machine()->I16x8UConvertI8x16Low(),
inputs[0]);
@@ -3408,17 +3408,17 @@ Node* WasmGraphBuilder::SimdOp(wasm::WasmOpcode opcode,
return graph()->NewNode(jsgraph()->machine()->I16x8MaxU(), inputs[0],
inputs[1]);
case wasm::kExprI16x8LtU:
- return graph()->NewNode(jsgraph()->machine()->I16x8LtU(), inputs[0],
- inputs[1]);
+ return graph()->NewNode(jsgraph()->machine()->I16x8GtU(), inputs[1],
+ inputs[0]);
case wasm::kExprI16x8LeU:
- return graph()->NewNode(jsgraph()->machine()->I16x8LeU(), inputs[0],
- inputs[1]);
- case wasm::kExprI16x8GtU:
- return graph()->NewNode(jsgraph()->machine()->I16x8LtU(), inputs[1],
+ return graph()->NewNode(jsgraph()->machine()->I16x8GeU(), inputs[1],
inputs[0]);
+ case wasm::kExprI16x8GtU:
+ return graph()->NewNode(jsgraph()->machine()->I16x8GtU(), inputs[0],
+ inputs[1]);
case wasm::kExprI16x8GeU:
- return graph()->NewNode(jsgraph()->machine()->I16x8LeU(), inputs[1],
- inputs[0]);
+ return graph()->NewNode(jsgraph()->machine()->I16x8GeU(), inputs[0],
+ inputs[1]);
case wasm::kExprI8x16Splat:
return graph()->NewNode(jsgraph()->machine()->I8x16Splat(), inputs[0]);
case wasm::kExprI8x16Neg:
@@ -3454,17 +3454,17 @@ Node* WasmGraphBuilder::SimdOp(wasm::WasmOpcode opcode,
return graph()->NewNode(jsgraph()->machine()->I8x16Ne(), inputs[0],
inputs[1]);
case wasm::kExprI8x16LtS:
- return graph()->NewNode(jsgraph()->machine()->I8x16LtS(), inputs[0],
- inputs[1]);
+ return graph()->NewNode(jsgraph()->machine()->I8x16GtS(), inputs[1],
+ inputs[0]);
case wasm::kExprI8x16LeS:
- return graph()->NewNode(jsgraph()->machine()->I8x16LeS(), inputs[0],
- inputs[1]);
- case wasm::kExprI8x16GtS:
- return graph()->NewNode(jsgraph()->machine()->I8x16LtS(), inputs[1],
+ return graph()->NewNode(jsgraph()->machine()->I8x16GeS(), inputs[1],
inputs[0]);
+ case wasm::kExprI8x16GtS:
+ return graph()->NewNode(jsgraph()->machine()->I8x16GtS(), inputs[0],
+ inputs[1]);
case wasm::kExprI8x16GeS:
- return graph()->NewNode(jsgraph()->machine()->I8x16LeS(), inputs[1],
- inputs[0]);
+ return graph()->NewNode(jsgraph()->machine()->I8x16GeS(), inputs[0],
+ inputs[1]);
case wasm::kExprI8x16UConvertI16x8:
return graph()->NewNode(jsgraph()->machine()->I8x16UConvertI16x8(),
inputs[0], inputs[1]);
@@ -3481,17 +3481,17 @@ Node* WasmGraphBuilder::SimdOp(wasm::WasmOpcode opcode,
return graph()->NewNode(jsgraph()->machine()->I8x16MaxU(), inputs[0],
inputs[1]);
case wasm::kExprI8x16LtU:
- return graph()->NewNode(jsgraph()->machine()->I8x16LtU(), inputs[0],
- inputs[1]);
+ return graph()->NewNode(jsgraph()->machine()->I8x16GtU(), inputs[1],
+ inputs[0]);
case wasm::kExprI8x16LeU:
- return graph()->NewNode(jsgraph()->machine()->I8x16LeU(), inputs[0],
- inputs[1]);
- case wasm::kExprI8x16GtU:
- return graph()->NewNode(jsgraph()->machine()->I8x16LtU(), inputs[1],
+ return graph()->NewNode(jsgraph()->machine()->I8x16GeU(), inputs[1],
inputs[0]);
+ case wasm::kExprI8x16GtU:
+ return graph()->NewNode(jsgraph()->machine()->I8x16GtU(), inputs[0],
+ inputs[1]);
case wasm::kExprI8x16GeU:
- return graph()->NewNode(jsgraph()->machine()->I8x16LeU(), inputs[1],
- inputs[0]);
+ return graph()->NewNode(jsgraph()->machine()->I8x16GeU(), inputs[0],
+ inputs[1]);
case wasm::kExprS128And:
return graph()->NewNode(jsgraph()->machine()->S128And(), inputs[0],
inputs[1]);
« no previous file with comments | « src/compiler/mips64/instruction-selector-mips64.cc ('k') | test/cctest/wasm/test-run-wasm-simd.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698