Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: src/compiler/mips64/code-generator-mips64.cc

Issue 2874403002: [wasm] Swap the implementation of SIMD compare ops using Gt/Ge insteas of Lt/Le (Closed)
Patch Set: Add Todo with bug reference Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/mips/instruction-selector-mips.cc ('k') | src/compiler/mips64/instruction-codes-mips64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/mips64/code-generator-mips64.cc
diff --git a/src/compiler/mips64/code-generator-mips64.cc b/src/compiler/mips64/code-generator-mips64.cc
index f4fb71d989b2587c55b6d400a6b59534c5568c8c..76e9d421816cd49ff47322fcebaafb483bf54476 100644
--- a/src/compiler/mips64/code-generator-mips64.cc
+++ b/src/compiler/mips64/code-generator-mips64.cc
@@ -2206,28 +2206,28 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
i.InputSimd128Register(0));
break;
}
- case kMips64I32x4LtS: {
+ case kMips64I32x4GtS: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ clt_s_w(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ clt_s_w(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
- case kMips64I32x4LeS: {
+ case kMips64I32x4GeS: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ cle_s_w(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ cle_s_w(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
- case kMips64I32x4LtU: {
+ case kMips64I32x4GtU: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ clt_u_w(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ clt_u_w(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
- case kMips64I32x4LeU: {
+ case kMips64I32x4GeU: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ cle_u_w(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ cle_u_w(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
case kMips64I16x8Splat: {
@@ -2331,16 +2331,16 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
__ nor_v(dst, dst, dst);
break;
}
- case kMips64I16x8LtS: {
+ case kMips64I16x8GtS: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ clt_s_h(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ clt_s_h(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
- case kMips64I16x8LeS: {
+ case kMips64I16x8GeS: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ cle_s_h(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ cle_s_h(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
case kMips64I16x8AddSaturateU: {
@@ -2367,16 +2367,16 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
i.InputSimd128Register(1));
break;
}
- case kMips64I16x8LtU: {
+ case kMips64I16x8GtU: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ clt_u_h(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ clt_u_h(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
- case kMips64I16x8LeU: {
+ case kMips64I16x8GeU: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ cle_u_h(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ cle_u_h(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
case kMips64I8x16Splat: {
« no previous file with comments | « src/compiler/mips/instruction-selector-mips.cc ('k') | src/compiler/mips64/instruction-codes-mips64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698