Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: src/compiler/mips/code-generator-mips.cc

Issue 2874403002: [wasm] Swap the implementation of SIMD compare ops using Gt/Ge insteas of Lt/Le (Closed)
Patch Set: Add Todo with bug reference Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/machine-operator.cc ('k') | src/compiler/mips/instruction-codes-mips.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/mips/code-generator-mips.cc
diff --git a/src/compiler/mips/code-generator-mips.cc b/src/compiler/mips/code-generator-mips.cc
index 5055735ba65db0928dc728b877a927c46a70240a..05f33aef905f51261cc8ddba0bf67446c42f59bd 100644
--- a/src/compiler/mips/code-generator-mips.cc
+++ b/src/compiler/mips/code-generator-mips.cc
@@ -1885,28 +1885,28 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
i.InputSimd128Register(0));
break;
}
- case kMipsI32x4LtS: {
+ case kMipsI32x4GtS: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ clt_s_w(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ clt_s_w(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
- case kMipsI32x4LeS: {
+ case kMipsI32x4GeS: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ cle_s_w(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ cle_s_w(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
- case kMipsI32x4LtU: {
+ case kMipsI32x4GtU: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ clt_u_w(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ clt_u_w(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
- case kMipsI32x4LeU: {
+ case kMipsI32x4GeU: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ cle_u_w(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ cle_u_w(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
case kMipsI16x8Splat: {
@@ -2010,16 +2010,16 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
__ nor_v(dst, dst, dst);
break;
}
- case kMipsI16x8LtS: {
+ case kMipsI16x8GtS: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ clt_s_h(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ clt_s_h(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
- case kMipsI16x8LeS: {
+ case kMipsI16x8GeS: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ cle_s_h(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ cle_s_h(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
case kMipsI16x8AddSaturateU: {
@@ -2046,16 +2046,16 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
i.InputSimd128Register(1));
break;
}
- case kMipsI16x8LtU: {
+ case kMipsI16x8GtU: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ clt_u_h(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ clt_u_h(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
- case kMipsI16x8LeU: {
+ case kMipsI16x8GeU: {
CpuFeatureScope msa_scope(masm(), MIPS_SIMD);
- __ cle_u_h(i.OutputSimd128Register(), i.InputSimd128Register(0),
- i.InputSimd128Register(1));
+ __ cle_u_h(i.OutputSimd128Register(), i.InputSimd128Register(1),
+ i.InputSimd128Register(0));
break;
}
case kMipsI8x16Splat: {
« no previous file with comments | « src/compiler/machine-operator.cc ('k') | src/compiler/mips/instruction-codes-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698