Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2904)

Unified Diff: chrome/browser/media/router/mojo/media_route_controller.h

Issue 2874283002: [Media Router] Notify MRUI of a media status update when it starts observing (Closed)
Patch Set: Address Mark's comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_route_controller.h
diff --git a/chrome/browser/media/router/mojo/media_route_controller.h b/chrome/browser/media/router/mojo/media_route_controller.h
index 5a5fab0bc132e11c94d9715cc02d71e9f550a224..9e70b1bef05d2cb1965529adb69e9e6872d7542d 100644
--- a/chrome/browser/media/router/mojo/media_route_controller.h
+++ b/chrome/browser/media/router/mojo/media_route_controller.h
@@ -52,6 +52,9 @@ class MediaRouteController : public mojom::MediaStatusObserver,
return controller_;
}
+ protected:
+ scoped_refptr<MediaRouteController> controller_;
+
private:
friend class MediaRouteController;
@@ -62,8 +65,6 @@ class MediaRouteController : public mojom::MediaStatusObserver,
// disposed. Overridden by subclasses to do custom cleanup.
virtual void OnControllerInvalidated();
- scoped_refptr<MediaRouteController> controller_;
-
DISALLOW_COPY_AND_ASSIGN(Observer);
};
@@ -96,6 +97,10 @@ class MediaRouteController : public mojom::MediaStatusObserver,
MediaRoute::Id route_id() const { return route_id_; }
+ const base::Optional<MediaStatus>& current_media_status() const {
mark a. foltz 2017/05/12 23:06:18 Document this method
takumif 2017/05/15 17:57:29 Done.
+ return current_media_status_;
+ }
+
protected:
~MediaRouteController() override;
@@ -129,6 +134,9 @@ class MediaRouteController : public mojom::MediaStatusObserver,
// This becomes false when the controller is invalidated.
bool is_valid_ = true;
+ // The latest media status that the controller has been notified with.
+ base::Optional<MediaStatus> current_media_status_;
+
DISALLOW_COPY_AND_ASSIGN(MediaRouteController);
};

Powered by Google App Engine
This is Rietveld 408576698