Fix local initializer execution

Fix local initializer execution

BUG=
R=dmitryas@google.com

Committed: https://github.com/dart-lang/sdk/commit/1dc564bc13cb5fe16e0b5494a77f7f104e4c086d

[zhivkag, 2017-05-11 14:57:59]

zhivkag@google.com changed reviewers:
+ dmitryas@google.com, kmillikin@google.com

[zhivkag, 2017-05-11 14:57:59]

Hi, 

This change modifies the execution of initializers in the initializer list. This
is needed because local initializers modify the initializer environment and
introduce variable declaration in scope for next initializers. 

Thanks, 
Zhivka

[Dmitry Stefantsov, 2017-05-15 07:31:37]

LGTM. I only have a couple of questions / suggestions.

https://codereview.chromium.org/2874253002/diff/20001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2874253002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:548: // Redirecting initializer is
not the only initializer.
Maybe we should assert here that all the initializers, except the last one, are
local initializers.

https://codereview.chromium.org/2874253002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:553:
_getExpression(constructor.initializers.first), ctrEnv, cont);
The first initializer can only be a LocalInitializer. We don't need to use
"_getExpression" here.

https://codereview.chromium.org/2874253002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:659: return new
ContinuationConfiguration(continuation, newObject);
Do I get it right that we assume that the super constructor invocation is the
last initializer in the list, if present?

[zhivkag, 2017-05-15 07:50:05]

Thanks!

https://codereview.chromium.org/2874253002/diff/20001/pkg/kernel/lib/interpre...
File pkg/kernel/lib/interpreter/interpreter.dart (right):

https://codereview.chromium.org/2874253002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:548: // Redirecting initializer is
not the only initializer.
On 2017/05/15 07:31:37, Dmitry Stefantsov wrote:
> Maybe we should assert here that all the initializers, except the last one,
are
> local initializers.

Done.

https://codereview.chromium.org/2874253002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:553:
_getExpression(constructor.initializers.first), ctrEnv, cont);
On 2017/05/15 07:31:37, Dmitry Stefantsov wrote:
> The first initializer can only be a LocalInitializer. We don't need to use
> "_getExpression" here.

Done.

https://codereview.chromium.org/2874253002/diff/20001/pkg/kernel/lib/interpre...
pkg/kernel/lib/interpreter/interpreter.dart:659: return new
ContinuationConfiguration(continuation, newObject);
On 2017/05/15 07:31:37, Dmitry Stefantsov wrote:
> Do I get it right that we assume that the super constructor invocation is the
> last initializer in the list, if present?

As we don't support super invocation in this CL, we just return when super is
invoked. 

Adding a "throw" (when superclass is not Object) to indicate it is not supported
instead.

[zhivkag, 2017-05-15 07:50:05]

Thanks!

[zhivkag, 2017-05-15 07:54:22]

Description was changed from

==========
Fix local initializer execution

BUG=
==========

to

==========
Fix local initializer execution

BUG=
R=dmitryas@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1dc564bc13cb5fe16e0b5494a77f7f104e4c086d
==========

[zhivkag, 2017-05-15 07:54:23]

Committed patchset #3 (id:40001) manually as
1dc564bc13cb5fe16e0b5494a77f7f104e4c086d (presubmit successful).