Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2874233003: DevTools: move group by product out of experiment (Closed)
Patch Set: fix test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
index dd6e58f0266822d2c2b7d3bb90c5754d0f9cb1d6..3e673ba711589210e6af3928482be6f6d81185da 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
@@ -238,8 +238,6 @@ Timeline.TimelineTreeView = class extends UI.VBox {
*/
refreshTree() {
this._linkifier.reset();
- if (this._searchableView)
- this._searchableView.cancelSearch();
this._dataGrid.rootNode().removeChildren();
if (!this._model) {
this._updateDetailsForSelection();
@@ -261,6 +259,8 @@ Timeline.TimelineTreeView = class extends UI.VBox {
}
this._sortingChanged();
this._updateDetailsForSelection();
+ if (this._searchableView)
+ this._searchableView.refreshSearch();
}
/**
@@ -636,8 +636,6 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
this._stackView = new Timeline.TimelineStackView(this);
this._stackView.addEventListener(
Timeline.TimelineStackView.Events.SelectionChanged, this._onStackViewSelectionChanged, this);
- if (!Runtime.experiments.isEnabled('timelineColorByProduct'))
- return;
/** @type {!Map<string, string>} */
this._productByURLCache = new Map();
ProductRegistry.instance().then(registry => {
@@ -752,8 +750,6 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
{label: Common.UIString('Group by Subdomain'), value: groupBy.Subdomain},
{label: Common.UIString('Group by URL'), value: groupBy.URL},
];
- if (!Runtime.experiments.isEnabled('timelineColorByProduct'))
- options = options.filter(option => option.value !== groupBy.Product);
toolbar.appendToolbarItem(new UI.ToolbarSettingComboBox(options, this._groupBySetting));
toolbar.appendSpacer();
toolbar.appendToolbarItem(this._splitWidget.createShowHideSidebarButton(Common.UIString('heaviest stack')));
@@ -863,7 +859,7 @@ Timeline.AggregatedTimelineTreeView = class extends Timeline.TimelineTreeView {
*/
_productByEvent(event) {
var url = TimelineModel.TimelineProfileTree.eventURL(event);
- if (!url || !this._productByURLCache)
+ if (!url)
return '';
if (this._productByURLCache.has(url))
return this._productByURLCache.get(url);
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698