DevTools: move group by product out of experiment

third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @unrestricted
  * @implements {UI.Searchable}
  */
 Timeline.TimelineTreeView = class extends UI.VBox {
   constructor() {
@@ skipping 220 matching lines @@
       gridNode.reveal();
       gridNode.select(suppressSelectedEvent);
     }
   }
 
   /**
    * @protected
    */
   refreshTree() {
     this._linkifier.reset();
-    if (this._searchableView)
-      this._searchableView.cancelSearch();
     this._dataGrid.rootNode().removeChildren();
     if (!this._model) {
       this._updateDetailsForSelection();
       return;
     }
     this._root = this._buildTree();
     var children = this._root.children();
     var maxSelfTime = 0;
     var maxTotalTime = 0;
     var totalUsedTime = this._root.totalTime - this._root.selfTime;
     for (var child of children.values()) {
       maxSelfTime = Math.max(maxSelfTime, child.selfTime);
       maxTotalTime = Math.max(maxTotalTime, child.totalTime);
     }
     for (var child of children.values()) {
       // Exclude the idle time off the total calculation.
       var gridNode = new Timeline.TimelineTreeView.TreeGridNode(child, totalUsedTime, maxSelfTime, maxTotalTime, this);
       this._dataGrid.insertChild(gridNode);
     }
     this._sortingChanged();
     this._updateDetailsForSelection();
+    if (this._searchableView)
+      this._searchableView.refreshSearch();
   }
 
   /**
    * @return {!TimelineModel.TimelineProfileTree.Node}
    */
   _buildTree() {
     throw new Error('Not Implemented');
   }
 
   /**
@@ skipping 355 matching lines @@
    */
   constructor(filters) {
     super();
     this._groupBySetting =
         Common.settings.createSetting('timelineTreeGroupBy', Timeline.AggregatedTimelineTreeView.GroupBy.None);
     this._groupBySetting.addChangeListener(this.refreshTree.bind(this));
     this.init(filters);
     this._stackView = new Timeline.TimelineStackView(this);
     this._stackView.addEventListener(
         Timeline.TimelineStackView.Events.SelectionChanged, this._onStackViewSelectionChanged, this);
-    if (!Runtime.experiments.isEnabled('timelineColorByProduct'))
-      return;
     /** @type {!Map<string, string>} */
     this._productByURLCache = new Map();
     ProductRegistry.instance().then(registry => {
       this._productRegistry = registry;
       this.refreshTree();
     });
   }
 
   /**
    * @override
@@ skipping 94 matching lines @@
     var options = [
       {label: Common.UIString('No Grouping'), value: groupBy.None},
       {label: Common.UIString('Group by Activity'), value: groupBy.EventName},
       {label: Common.UIString('Group by Category'), value: groupBy.Category},
       {label: Common.UIString('Group by Domain'), value: groupBy.Domain},
       {label: Common.UIString('Group by Frame'), value: groupBy.Frame},
       {label: Common.UIString('Group by Product'), value: groupBy.Product},
       {label: Common.UIString('Group by Subdomain'), value: groupBy.Subdomain},
       {label: Common.UIString('Group by URL'), value: groupBy.URL},
     ];
-    if (!Runtime.experiments.isEnabled('timelineColorByProduct'))
-      options = options.filter(option => option.value !== groupBy.Product);
     toolbar.appendToolbarItem(new UI.ToolbarSettingComboBox(options, this._groupBySetting));
     toolbar.appendSpacer();
     toolbar.appendToolbarItem(this._splitWidget.createShowHideSidebarButton(Common.UIString('heaviest stack')));
   }
 
   /**
    * @param {!TimelineModel.TimelineProfileTree.Node} treeNode
    * @return {!Array<!TimelineModel.TimelineProfileTree.Node>}
    */
   _buildHeaviestStack(treeNode) {
@@ skipping 89 matching lines @@
     var domainMatch = /([^.]*\.)?[^.]*$/.exec(parsedURL.host);
     return domainMatch && domainMatch[0] || '';
   }
 
   /**
    * @param {!SDK.TracingModel.Event} event
    * @return {string}
    */
   _productByEvent(event) {
     var url = TimelineModel.TimelineProfileTree.eventURL(event);
-    if (!url || !this._productByURLCache)
+    if (!url)
       return '';
     if (this._productByURLCache.has(url))
       return this._productByURLCache.get(url);
     if (!this._productRegistry)
       return '';
     var parsedURL = url.asParsedURL();
     var name = parsedURL && this._productRegistry.nameForUrl(parsedURL) || '';
     this._productByURLCache.set(url, name);
     return name;
   }
@@ skipping 140 matching lines @@
 
   _onSelectionChanged() {
     this.dispatchEventToListeners(Timeline.TimelineStackView.Events.SelectionChanged);
   }
 };
 
 /** @enum {symbol} */
 Timeline.TimelineStackView.Events = {
   SelectionChanged: Symbol('SelectionChanged')
 };