tools/metrics/histograms/histograms.xml - Issue 2874193003: [PageLoadMetrics] Ignore ad frames with no content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2874193003: [PageLoadMetrics] Ignore ad frames with no content (Closed)

Patch Set: Rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 441ddd975759eec65eb5b4aac562b77333853c84..a33426650a773fb07a7ee0e6e7e5a0f321d7f1f6 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -47426,7 +47426,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

units="Ad frames">

<owner>jkarlin@chromium.org</owner>

- The number of frames on the page identified as Google Ad Frames.

+ The number of frames on the page identified as Google Ad Frames that have

+ loaded more than 0 bytes of content.

For pages with zero ad frames, the other PageLoad.Clients.Ads metrics are

not recorded unless otherwise specified.

@@ -47438,6 +47439,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram

name="PageLoad.Clients.Ads.Google.FrameCounts.MainFrameParent.AdFrames"

units="Frames">

+ <obsolete>

+ Deprecated In May 2017.

+ </obsolete>

<owner>jkarlin@chromium.org</owner>

The number of frames (with parent frame of main frame) that are on the page

@@ -47451,6 +47455,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram

name="PageLoad.Clients.Ads.Google.FrameCounts.MainFrameParent.PercentAdFrames"

units="%">

+ <obsolete>

+ Deprecated In May 2017.

+ </obsolete>

<owner>jkarlin@chromium.org</owner>

The percentage of frames (with parent frame of main frame) on the page that

@@ -47465,6 +47472,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram

name="PageLoad.Clients.Ads.Google.FrameCounts.MainFrameParent.TotalFrames"

units="Frames">

+ <obsolete>

+ Deprecated In May 2017.

+ </obsolete>

<owner>jkarlin@chromium.org</owner>

The number of frames (with parent frame of main frame) on the page.

« no previous file with comments | « chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc ('k') | no next file » | no next file with comments »