Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2874193002: Fix bug in test_runner.dart (Closed)

Created:
3 years, 7 months ago by Bill Hesse
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, Johnni Winther, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bug in test_runner.dart This error was introduced in https://codereview.chromium.org/2875683002/ committed as d6ca1a5defcbe3834d08a67511abc23bb902f073. BUG= TBR=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/bff560292ced495622771b668a0689167b2b4f81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/testing/dart/test_runner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Bill Hesse
3 years, 7 months ago (2017-05-11 11:38:26 UTC) #1
Bill Hesse
Committed patchset #1 (id:1) manually as bff560292ced495622771b668a0689167b2b4f81 (presubmit successful).
3 years, 7 months ago (2017-05-11 11:39:52 UTC) #3
Johnni Winther
lgtm
3 years, 7 months ago (2017-05-11 11:52:19 UTC) #5
karlklose
3 years, 7 months ago (2017-05-11 12:00:17 UTC) #6
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698