Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

Issue 2874133002: Removed WebFrameClient.cpp from Source/web (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
index f75782211ad5915d4b7dff6cfca99b06db745d68..21fdd2b1a96f0caddc2367d4d87b6f7b1dfd4bae 100644
--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
@@ -321,6 +321,17 @@ void WebEmbeddedWorkerImpl::LoadShadowPage() {
SubstituteData(buffer, "text/html", "UTF-8", KURL())));
}
+void WebEmbeddedWorkerImpl::FrameDetached(WebLocalFrame* frame,
+ DetachType type) {
+ if (type == DetachType::kRemove && frame->Parent())
+ frame->Parent()->RemoveChild(frame);
kinuko.yasuda 2017/05/11 04:07:17 I think we can remove this (and possibly below) an
sashab 2017/05/15 02:18:02 Added TODOs for both :) Will do in follow-up patch
dcheng 2017/05/15 03:58:47 Given that we fixed up the other places (in WebVie
sashab 2017/05/15 06:23:48 Done :)
+
+ if (frame->FrameWidget())
+ frame->FrameWidget()->Close();
+
+ frame->Close();
+}
+
void WebEmbeddedWorkerImpl::DidFinishDocumentLoad() {
DCHECK(!main_script_loader_);
DCHECK(main_frame_);

Powered by Google App Engine
This is Rietveld 408576698