Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: content/browser/web_contents/web_contents_view_aura_browsertest.cc

Issue 287413002: Disable WebContentsViewAuraTest.OverscrollNavigation which is flaky under both Win and CrOS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_view_aura.h" 5 #include "content/browser/web_contents/web_contents_view_aura.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/test/test_timeouts.h" 10 #include "base/test/test_timeouts.h"
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 void set_min_screenshot_interval(int interval_ms) { 260 void set_min_screenshot_interval(int interval_ms) {
261 screenshot_manager_->SetScreenshotInterval(interval_ms); 261 screenshot_manager_->SetScreenshotInterval(interval_ms);
262 } 262 }
263 263
264 private: 264 private:
265 ScreenshotTracker* screenshot_manager_; 265 ScreenshotTracker* screenshot_manager_;
266 266
267 DISALLOW_COPY_AND_ASSIGN(WebContentsViewAuraTest); 267 DISALLOW_COPY_AND_ASSIGN(WebContentsViewAuraTest);
268 }; 268 };
269 269
270 // Flaky on Windows (perhaps just Win-Aura): http://crbug.com/305722 270 // Flaky on Windows and ChromeOS: http://crbug.com/305722
271 #if defined(OS_WIN) 271 IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest,
272 #define MAYBE_OverscrollNavigation DISABLED_OverscrollNavigation 272 DISABLED_OverscrollNavigation) {
273 #else
274 #define MAYBE_OverscrollNavigation OverscrollNavigation
275 #endif
276 IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, MAYBE_OverscrollNavigation) {
277 TestOverscrollNavigation(false); 273 TestOverscrollNavigation(false);
278 } 274 }
279 275
280 // Flaky on Windows (perhaps just Win-Aura): http://crbug.com/305722 276 // Flaky on Windows (might be related to the above test):
277 // http://crbug.com/305722
281 #if defined(OS_WIN) 278 #if defined(OS_WIN)
282 #define MAYBE_OverscrollNavigationWithTouchHandler \ 279 #define MAYBE_OverscrollNavigationWithTouchHandler \
283 DISABLED_OverscrollNavigationWithTouchHandler 280 DISABLED_OverscrollNavigationWithTouchHandler
284 #else 281 #else
285 #define MAYBE_OverscrollNavigationWithTouchHandler \ 282 #define MAYBE_OverscrollNavigationWithTouchHandler \
286 OverscrollNavigationWithTouchHandler 283 OverscrollNavigationWithTouchHandler
287 #endif 284 #endif
288 IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest, 285 IN_PROC_BROWSER_TEST_F(WebContentsViewAuraTest,
289 MAYBE_OverscrollNavigationWithTouchHandler) { 286 MAYBE_OverscrollNavigationWithTouchHandler) {
290 TestOverscrollNavigation(true); 287 TestOverscrollNavigation(true);
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 10); 675 10);
679 base::string16 actual_title = title_watcher.WaitAndGetTitle(); 676 base::string16 actual_title = title_watcher.WaitAndGetTitle();
680 EXPECT_EQ(expected_title, actual_title); 677 EXPECT_EQ(expected_title, actual_title);
681 678
682 EXPECT_EQ(2, GetCurrentIndex()); 679 EXPECT_EQ(2, GetCurrentIndex());
683 EXPECT_TRUE(controller.CanGoBack()); 680 EXPECT_TRUE(controller.CanGoBack());
684 EXPECT_FALSE(controller.CanGoForward()); 681 EXPECT_FALSE(controller.CanGoForward());
685 } 682 }
686 683
687 } // namespace content 684 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698