third_party/WebKit/LayoutTests/http/tests/images/force-reload.html - Issue 2874073003: Add layout tests for ImageLoader::UpdateFromElement(kUpdateForcedReload)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/images/force-reload.html

Issue 2874073003: Add layout tests for ImageLoader::UpdateFromElement(kUpdateForcedReload) (Closed)

Patch Set: fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>

	5 var t = async_test("ForceReload should get a new image for an <img> element");

	6 function triggerReload() {

	7 var img = document.getElementById('img');

	8 var originalWidth = img.width;

	9 var originalHeight = img.height;

	10

	11 img.onload = t.step_func_done(function() {

	12 assert_not_equals(originalWidth, img.width, "Should be reloaded: width");

	13 assert_not_equals(originalHeight, img.height, "Should be reloaded: height");

	14 });

	15
	yhirano 2017/05/12 10:30:43 +img.onerror +img.onerror hiroshige 2017/05/12 17:14:51 Done. Show quoted text On 2017/05/12 10:30:43, yhirano wrote: > +img.onerror Done.
	16 if (window.internals) {

	17 internals.forceImageReload(img);

	18 }

	19 }

	20 </script>

	21

	22 <!-- We call triggerReload() strictly after document load event,

	23 because reloading is not enforced until document load event is finished. -->

	24 <body onload="setTimeout(t.step_func(triggerReload), 0)">

	25 <img id="img" src="../cache/resources/random-cached-image.php?id=1">
	yhirano 2017/05/12 10:30:43 [optional] I think using the test name as id is sa [optional] I think using the test name as id is safer because it's harder to misuse. hiroshige 2017/05/12 17:14:51 Done. Show quoted text On 2017/05/12 10:30:43, yhirano wrote: > [optional] I think using the test name as id is safer because it's harder to > misuse. Done.
	26 </body>

OLD	NEW