third_party/WebKit/LayoutTests/http/tests/images/force-reload-image-document.html - Issue 2874073003: Add layout tests for ImageLoader::UpdateFromElement(kUpdateForcedReload)

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/images/force-reload-image-document.html

Issue 2874073003: Add layout tests for ImageLoader::UpdateFromElement(kUpdateForcedReload) (Closed)

Patch Set: Comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/images/force-reload.html ('k') | third_party/WebKit/Source/core/testing/Internals.h » ('j') | third_party/WebKit/Source/core/testing/Internals.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>

	5 // This tests ImageLoader/ImageDocument implementation in Blink.

	6 var t = async_test("ForceReload should not crash for an image document");

	7

	8 function triggerReload() {

	9 // This depends on how image documents are implemented by Blink.

	10 var iframe = document.getElementById('iframe');

	11 var img = iframe.contentDocument.body.getElementsByTagName('img')[0];

	12

	13 img.onload = t.step_func_done(function() {

	14 // TODO(hiroshige): Check that the image is actually reloaded.

	15 // We need an URL that returns different non-SVG images for each reload.
	kouhei (in TOK) 2017/05/11 16:50:52 fix todo? fix todo? hiroshige 2017/05/11 17:11:44 Hmm. One way to do this is to have .cgi page (or . Show quoted text On 2017/05/11 16:50:52, kouhei (on transit) wrote: > fix todo? Hmm. One way to do this is to have .cgi page (or .php or something) to count the number of requests (by writing to a file on temp dir) and switch some predefined imaged based on the request count. This might be not super-clean (especially multiple tests accessing to the .cgi are running at the same time) though, but the similar thing is already done in some other tests (e.g. third_party/WebKit/LayoutTests/http/tests/resources/network-simulator.php). kouhei (in TOK) 2017/05/11 17:30:14 I see. I don't see a super clean way to do this. M Show quoted text On 2017/05/11 17:11:44, hiroshige wrote: > On 2017/05/11 16:50:52, kouhei (on transit) wrote: > > fix todo? > > Hmm. One way to do this is to have .cgi page (or .php or something) to count the > number of requests (by writing to a file on temp dir) and switch some predefined > imaged based on the request count. > This might be not super-clean (especially multiple tests accessing to the .cgi > are running at the same time) though, but the similar thing is already done in > some other tests (e.g. > third_party/WebKit/LayoutTests/http/tests/resources/network-simulator.php). I see. I don't see a super clean way to do this. May be omit the test? hiroshige 2017/05/11 18:12:15 This test is necessary to confirm there's no crash Show quoted text On 2017/05/11 17:30:14, kouhei (on transit) wrote: > On 2017/05/11 17:11:44, hiroshige wrote: > > On 2017/05/11 16:50:52, kouhei (on transit) wrote: > > > fix todo? > > > > Hmm. One way to do this is to have .cgi page (or .php or something) to count > the > > number of requests (by writing to a file on temp dir) and switch some > predefined > > imaged based on the request count. > > This might be not super-clean (especially multiple tests accessing to the .cgi > > are running at the same time) though, but the similar thing is already done in > > some other tests (e.g. > > third_party/WebKit/LayoutTests/http/tests/resources/network-simulator.php). > I see. I don't see a super clean way to do this. May be omit the test? This test is necessary to confirm there's no crashes. (This test executes a code path in ImageLoader that no other tests execute) Updated the tests in Patch Set 5. I made the php script to count the number of request separately for different id parameter to avoid race conditions between different tests. WDYT?
	16 });

	17

	18 if (window.internals) {

	19 internals.forceImageReload(img);

	20 }

	21 }

	22 </script>

	23

	24 <!-- We call triggerReload() strictly after document load event,

	25 because reloading is not enforced until document load event is finished. -->

	26 <body onload="setTimeout(t.step_func(triggerReload), 0)">

	27 <iframe id="iframe" src="../resources/square100.png"></iframe>

	28 </body>

OLD	NEW