Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2780)

Unified Diff: chrome/browser/ui/android/page_info/page_info_popup_android.h

Issue 2874073002: [subresource_filter] Always display the default setting in Android Page Info (Closed)
Patch Set: add dep PS and refactor Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/android/page_info/page_info_popup_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/android/page_info/page_info_popup_android.h
diff --git a/chrome/browser/ui/android/page_info/page_info_popup_android.h b/chrome/browser/ui/android/page_info/page_info_popup_android.h
index e7b6c893e7f4369d1ed24b0ff680fd197846ec66..fe8000a100cccbd1fe350a7c37b3b075ed087787 100644
--- a/chrome/browser/ui/android/page_info/page_info_popup_android.h
+++ b/chrome/browser/ui/android/page_info/page_info_popup_android.h
@@ -11,6 +11,7 @@
#include "base/android/scoped_java_ref.h"
#include "base/macros.h"
+#include "base/optional.h"
#include "chrome/browser/ui/page_info/page_info_ui.h"
namespace content {
@@ -51,6 +52,13 @@ class PageInfoPopupAndroid : public PageInfoUI {
static bool RegisterPageInfoPopupAndroid(JNIEnv* env);
private:
+ // Returns an optional value which is set if this permission should be
+ // displayed in Page Info. Most permissions will only be displayed if they are
+ // set to some non-default value, but there are some permissions which require
+ // customized behavior.
+ base::Optional<ContentSetting> GetSettingToDisplay(
+ const PermissionInfo& permission);
+
// The presenter that controlls the Page Info UI.
std::unique_ptr<PageInfo> presenter_;
« no previous file with comments | « no previous file | chrome/browser/ui/android/page_info/page_info_popup_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698