Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2874053002: Fix method call type inference with explicit type parameters. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
Leaf, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix method call type inference with explicit type parameters. This was broken for three reasons: - We weren't recording the fact that the type parameters were explicitly provided, so the inference code path to handle this case wasn't being exercised. - The inference code path to handle this case was accidentally referring to the `inferredTypes` variable, which is `null` in this case. - We were not checking for the case where the user provided the wrong number of type parameters. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/e68668f88d22eb188d4746da0577bd97f62595f4

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-10 17:51:50 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-10 17:54:54 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-10 18:00:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e68668f88d22eb188d4746da0577bd97f62595f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698